Skip to content

finish jv-oop#2569

Closed
letorak wants to merge 2 commits intomate-academy:masterfrom
letorak:solution
Closed

finish jv-oop#2569
letorak wants to merge 2 commits intomate-academy:masterfrom
letorak:solution

Conversation

@letorak
Copy link
Copy Markdown

@letorak letorak commented Mar 26, 2026

No description provided.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Great job on implementing the class hierarchy and the core logic! Your solution correctly uses inheritance and polymorphism. However, changes are needed because the comments in src/main/java/core/basesyntax/MainApp.java are not written in English. This violates one of the project's requirements, as stated in [CHECKLIST ITEM #2]. Please translate all comments to English to ensure consistency across the codebase. Once that's done, your solution will be ready for approval!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example


public class MainApp {
public static void main(String[] args) {
// Створюємо масив типу Machine і кладемо туди наші об'єкти
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: 'Use English only'. Please ensure all comments are written in English to maintain consistency in the codebase.

new Excavator()
};

// Проходимо циклом по кожній машині
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: 'Use English only'. Please ensure all comments are written in English.

@letorak letorak closed this Mar 26, 2026
@letorak letorak deleted the solution branch March 26, 2026 09:41
@letorak letorak restored the solution branch March 26, 2026 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants