Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Good work on this task! You've correctly used SCSS features like variables and loops, and the BEM structure is well-applied. However, a few changes are needed to meet the core requirements.
Here are the issues to address:
- Calendar Centering: The calendar is not centered horizontally due to
margin-left: 20px;insrc/styles/index.scss. Please remove this property to allow the parent flex container to center the element correctly. - Stylesheet Naming: The task requires the stylesheet to be named
main.scss. Please renamesrc/styles/index.scsstosrc/styles/main.scssand update thehrefinsrc/index.html. month-lengthModifiers: The@forloop in your SCSS generates modifiers for month lengths 1 through 31, but the requirement is specifically for 28, 29, 30, and 31. Please adjust the loop to create only these four required classes.
Once these points are fixed, your solution will be perfect. Keep up the great effort!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job addressing most of the feedback from the previous review! The calendar centering and file structure are now correct. However, one critical requirement still needs to be fixed before this can be approved. In src/styles/main.scss, your @for loop for the month-length modifier is generating classes for all values from 1 to 31, but the task requires generating these modifiers only for the values 28, 29, 30, and 31. Please adjust your SASS loop to generate only these four required classes. You're very close to a perfect solution!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work! I am approving your solution as you have successfully addressed all the feedback from the previous review and met every requirement perfectly. Your use of SASS loops to generate the start-day and month-length modifiers is now spot-on, and the HTML structure is clean and well-organized with proper BEM conventions. [CHECKLIST ITEM #2] The calendar functions exactly as expected, and the code is clean and maintainable. Great job on this submission!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
DEMO LINK
TEST REPORT LINK
Changing 'month-lengh' and 'start-day' modifier in the code element
reflects in changing calendar layout
Each day has no modifiers, only class (eg. calendar__day)
All
Typical MistakesfromBEMlesson theory are checked.Code follows all the Code Style Rules ❗️