Skip to content
Closed
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
/backstop_data
/dist
2 changes: 1 addition & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module.exports = {
extends: ['@mate-academy/eslint-config', 'plugin:cypress/recommended'],
extends: '@mate-academy/eslint-config',
};
3 changes: 1 addition & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@ name: Test

on:
pull_request:
branches: [ master ]
branches: [main]

jobs:
build:

runs-on: ubuntu-latest

strategy:
Expand Down
29 changes: 29 additions & 0 deletions .github/workflows/test.yml-template
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
name: Test

on:
pull_request:
branches: [ master ]

jobs:
build:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
- name: Upload HTML report(backstop data)
if: ${{ always() }}
uses: actions/upload-artifact@v2
with:
name: report
path: backstop_data
26 changes: 26 additions & 0 deletions .github/workflows/test.yml.save
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
name: Test

on:
pull_request:
branches: [master]

jobs:
build:
runs-on: ubuntu-latest

strategy:
matrix:
node-version: [20.x]

steps:
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm start & sleep 5 && npm test
- name: Upload tests report(cypress mochaawesome merged HTML report)
if: ${{ always() }}
uses: actions/upload-artifact@v4

5 changes: 1 addition & 4 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,7 @@ node_modules
.DS_Store

# Generated files
backstop_data
dist
.cache
.parcel-cache
raw_reports
cypress/screenshots
cypress/videos
reports
1 change: 1 addition & 0 deletions .stylelintignore
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
/backstop_data/
/dist
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,9 @@ Follow the instructions in this and next lessons to implement the page block by
- Start writing styles in the `main.scss` file. It is be explained in the `Sass` lesson.
- **DON'T** try to do it `Pixel Perfect` - implement it the most `simple` way so it looks similar.
- When done check yourself using the [CHECKLIST](./checklist.md) when finished.
- Deploy and create a Pull Request with a [DEMO LINK](https://<your_account>.github.io/layout_landing-page/).
- Deploy and create a Pull Request with a [DEMO LINK](https://github.com/dsliusarchyk/layout_landing-page.git/).

# Tips & Hints

- Check `background-image: url()` to be relative to the `main.scss`. So should start with `../images`.
- If some points from the checklist are not relevant to your design, just skip it.
2 changes: 1 addition & 1 deletion checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,6 @@
14. Placeholders should give examples of what should be added, to make the expected format clear
15. The page shouldn't be reloaded on form submit, but the fields should be cleared. Use:
```html
<form onsubmit="this.reset(); return false;">
<form onsubmit="this.reset(); return false;"></form>
```
16. Make the `footer` sticky at the bottom with `z-index: -1` to get a `fixed` background effect.
Loading