Conversation
Moises-S001
commented
Jan 4, 2026
Moises-S001
commented
- When done check yourself using the CHECKLIST when finished.
- Deploy and create a Pull Request with a DEMO LINK.
|
sei que não esta totalmente concluído mas queria ter umas dicas de como melhorar para atividade ficar mais próximo do ideal |
IanLuan
left a comment
IanLuan
left a comment
There was a problem hiding this comment.
You’re on the right track. Your code looks good, and you’re almost there. Now try to make it closer to the mockup by reviewing font sizes, content alignment, spacing, container sizes, and the image grid. Aim to follow the layout and core design principles of the mockup. Once you finish these adjustments, we can do a deeper review of your code.
IanLuan
left a comment
IanLuan
left a comment
There was a problem hiding this comment.
Your DEMO link is not working. Please deploy it again.
|
https://moises-s001.github.io/layout_landing-page/ |
raulriato
left a comment
raulriato
left a comment
There was a problem hiding this comment.
You are missing a lot of the items from the checklist.
Your page does not look bad, you did a good job, just need to fix these points and you'll be good to go
| <script | ||
| src="src/scripts/main.js" | ||
| defer | ||
| ></script> |
There was a problem hiding this comment.
- Use the logo as a favicon
- Use the landing name as a page title
| <p>+1 212-923-3700</p> | ||
| <p>Address</p> | ||
| <p>99 Margaret Corbin Drive<br> Fort Tryon Park <br> New York, NY 10040</p> | ||
| </div> |
There was a problem hiding this comment.
- Change text color on hover for phone, email, and address
index.html
Outdated
| <h3>The Met Fifth Avenue</h3> | ||
|
|
||
| <p>Phone</p> | ||
| <p>+1 212-535-7710</p> |
There was a problem hiding this comment.
- Make sure phone icons and phone numbers are real links to start a call
index.html
Outdated
| <p>Phone</p> | ||
| <p>+1 212-535-7710</p> | ||
| <p>Address</p> | ||
| <p>1000 Fifth Avenue <br> New York, NY 10028</p> |
There was a problem hiding this comment.
- All addresses should be links to some location on Google Maps. Open them in a new tab with target="_blank".
index.html
Outdated
| <article class="exhibition-card"> | ||
|
|
||
| <div class="img-box"> | ||
| <img class="img" src="./src/imagens/img-content-page/Layer54.png" alt="Layer46"> |
There was a problem hiding this comment.
- Increase all images on hover (make them links to #, if there is no better option)
There was a problem hiding this comment.
todas as imagens deve ser um link ? e todas tem que aumentar o tamanho quando passa o mouse?
| <div class="img-box"> | ||
| <img class="img --extend" src="./src/imagens/img-content-page/Layer46.png" alt="Layer46"> | ||
| <img class="img --standard" src="./src/imagens/img-content-page/Layer47.png" alt="Layer47"> | ||
| </div> |
There was a problem hiding this comment.
These images are not matching the mockup
| <a href="#" class="menu__call-to-order">call to order</a> | ||
| </div> | ||
|
|
||
| </aside> |
There was a problem hiding this comment.
- Disable page scrolling under the menu using the next code:
.page:has(.page__menu:target) {
overflow: hidden; /* not to scroll the page */
}There was a problem hiding this comment.
Make it possible to scroll the menu if it is higher than the viewport;
.menu {
overflow: auto; /* to scroll the menu if needed */
}
.menu__top {
position: sticky; /* to keep cross always visible */
top: 0;
z-index: 1;
background-color: #e5e5e5;
}| <textarea name="message" id="message" | ||
| placeholder="message" class="message_contact"></textarea> | ||
| <button type="submit" class="button_contact">Send</button> | ||
| </form> |
There was a problem hiding this comment.
- All form fields should be required and have correct types (email, tel, etc.)
index.html
Outdated
| class="form_input-contact"> | ||
|
|
||
| <textarea name="message" id="message" | ||
| placeholder="message" class="message_contact"></textarea> |
There was a problem hiding this comment.
- Placeholders should give examples of what should be added, to make the expected format clear
|
|
||
| <footer class="footer"> | ||
| <div class="footer"></div> | ||
| </footer> |
There was a problem hiding this comment.
- Make the footer sticky at the bottom with z-index: -1 to get a fixed background effect.
IanLuan
left a comment
IanLuan
left a comment
There was a problem hiding this comment.
Well done, it looks really good! I’m accepting your task, but here are a few things to improve:
- The footer is missing the
position: stickystyle to create the fixed background effect. You’ll also need to addbackground-color: whiteto themainelement. - The
header_titlefont size should be 80px on desktop.
3 participants
