add task solution landing-page#2946
Conversation
etojeDenys
left a comment
There was a problem hiding this comment.
problems have not been fixed. make sure you deploy the changes
Anton-Kuchmasov
left a comment
There was a problem hiding this comment.
Your solution is not ready yet.
Please implement design for three devices' types: mobile, tablet, PC.
Thread in fe_chat with feedback and suggestions:
https://mate.academy/chats/20895?selectedMessageId=9919451
etojeDenys
left a comment
There was a problem hiding this comment.
great progress. let's improve your page
-
all fields should be required
-
this button should be smaller in the desktop version
- make sure that all of your buttons follow this mockup
-
use higher-quality images on the desktop version
-
slightly increase the scale of images when hovering them
-
pay attention to the space here
layout:
your page should have it as well
- add a hover effect to the header elements
- add a title and favicon to the page
Denys-Kravchuk9988
left a comment
There was a problem hiding this comment.
Good job!
A few things to improve:
- On desktop the size of these icons should be 32x32 according to the design
- I would recommend to add
cursor: pointerwhen user hovers these images
- It's better to remove autofill styles
- Send button should have height 56px on desktop according to the design
- The line should have as equal width as text
- The color of text when user hovers the link should be
#292929
- For better quality of images I would recommend to export them in 2x scale from Figma and then convert it to
.avifand.webpformat
etojeDenys
left a comment
There was a problem hiding this comment.
demo link does not work. please fix it and request the review again












DEMO LINK