Skip to content

add task solution landing-page#2946

Open
valerij0412 wants to merge 13 commits intomate-academy:mainfrom
valerij0412:develop
Open

add task solution landing-page#2946
valerij0412 wants to merge 13 commits intomate-academy:mainfrom
valerij0412:develop

Conversation

@valerij0412
Copy link

@valerij0412 valerij0412 commented Jan 17, 2026

Copy link

@vitalii-bondarenko-ua vitalii-bondarenko-ua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • menu should be open or not. Now it always below header.
Screenshot 2026-01-17 at 17 13 36 - almost all sections of landing doesn't match to design. In general landings looks like not finished. Please make next re-request after finish all sections. Screenshot 2026-01-17 at 17 14 18 Screenshot 2026-01-17 at 17 14 24

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

problems have not been fixed. make sure you deploy the changes

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

page still looks broken. please fix it
image

Copy link

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your solution is not ready yet.
Please implement design for three devices' types: mobile, tablet, PC.
Thread in fe_chat with feedback and suggestions:
https://mate.academy/chats/20895?selectedMessageId=9919451

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great progress. let's improve your page

  1. all fields should be required

  2. this button should be smaller in the desktop version

Image
  1. make sure that all of your buttons follow this mockup
Image
  1. use higher-quality images on the desktop version

  2. slightly increase the scale of images when hovering them

  3. pay attention to the space here
    layout:

Image your page should have it as well
  1. add a hover effect to the header elements
Image
  1. add a title and favicon to the page
Image

Copy link

@Denys-Kravchuk9988 Denys-Kravchuk9988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

A few things to improve:

  1. On desktop the size of these icons should be 32x32 according to the design
Image
  1. I would recommend to add cursor: pointer when user hovers these images
Image
  1. It's better to remove autofill styles
Image
  1. Send button should have height 56px on desktop according to the design
Image
  1. The line should have as equal width as text
Image Image
  1. The color of text when user hovers the link should be #292929
Image Image
  1. For better quality of images I would recommend to export them in 2x scale from Figma and then convert it to .avif and .webp format
Image Image

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

demo link does not work. please fix it and request the review again

Copy link

@2pasha 2pasha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job! 👏

here are some improvements:

  1. issue with favicon is still actual
Image
  1. fix layout for phone number
Image
  1. change font
Image Image Image
  1. add form validation
  • all fields should be required
  • add email validation
Image
  1. remove base borders
Image
  1. after using nav link this icon doesn't change back
Image
  1. fix gaps here on tablet
Image

@valerij0412 valerij0412 requested a review from 2pasha February 22, 2026 15:57
Copy link

@vitalii-bondarenko-ua vitalii-bondarenko-ua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants