Skip to content

add task solution#2983

Open
StasParubets wants to merge 8 commits intomate-academy:mainfrom
StasParubets:develop
Open

add task solution#2983
StasParubets wants to merge 8 commits intomate-academy:mainfrom
StasParubets:develop

Conversation

@StasParubets
Copy link

No description provided.

Copy link

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, try to complete the whole task. Also, please provide the DEMO Link before PR submit

@StasParubets
Copy link
Author

DEMO LINK

Copy link

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good progress, almost done:

  1. Let`s add some slide animation for opening the menu.
  2. Add z-index property to Footer.
  3. Add hover effect to all images and buttons.
  4. Remove watermark from this image:
Image

Copy link

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comments from my previous review have not been resolved, also after submit the contact form it should not jump to top.

Copy link

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job you did!

To improve:

  1. When User selects one of predefined input values, no style changes allowed (such as background-color of input field or whatever else):
Image

Use CSS autofill docs to proceed

  1. After clicking a Send button, form should be wiped - no other actions requires. Use #15 of this instruction

  2. On big screen (laptops or PC with screen width > 1024px) an image of brake looks sligthly weird:

Image

Would you mind to use <picture> or even srcset attribute to use several images for different devices?

Copy link

@FaiHamid FaiHamid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
Let`s just fix a few things:

1.Title should be a bit lower
Image
Image

2.After click on Send it should cleare the form instead of refresh page
Image

Copy link

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost done:

  1. Add z-index to Footer with goal to reach the slide effect.
  2. Add hovers to all this links:
Image

Copy link

@brespect brespect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants