-
Notifications
You must be signed in to change notification settings - Fork 6.1k
style: fix header layout and spacing #7477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
frolova11
wants to merge
14
commits into
mate-academy:master
Choose a base branch
from
frolova11:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
b7b143c
style: fix header layout and spacing
frolova11 72b3263
fix: address mentor feedback
frolova11 f37f94b
fix: remove duplicated class attribute
frolova11 2eaef15
fix: restore active class and correct font link
frolova11 aded351
fix: wrap font URL in link tag
frolova11 8e6b57d
fix: final font link cleanup
frolova11 065f608
fix: final cleanup of head and navigation classes
frolova11 15ce87c
fix: force update to trigger new AI check
frolova11 4d9c053
fix: remove trailing newline and check styles
frolova11 f509a65
style: fix linter issues and pseudo-elements
frolova11 90cdebd
style: fix spacing and linter rules
frolova11 406593d
fix: target body element and fix linter spacing
frolova11 8ab412f
fix: final cleanup of selectors and links
frolova11 5f92b1c
style: remove duplicate selector and clean up
frolova11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,60 @@ | ||
| :root { | ||
| --color-blue: #00acdc; | ||
| } | ||
|
|
||
| body { | ||
| margin: 0; | ||
| font-family: Roboto, Arial, sans-serif; | ||
| font-weight: 500; | ||
| font-size: 12px; | ||
| letter-spacing: 0; | ||
| } | ||
|
|
||
| .header { | ||
| display: flex; | ||
| padding: 0 50px; | ||
| justify-content: space-between; | ||
| align-items: center; | ||
| } | ||
|
|
||
| .nav__link { | ||
| text-transform: uppercase; | ||
| color: inherit; | ||
| white-space: nowrap; | ||
| outline: none; | ||
| text-decoration: none; | ||
| font-size: 12px; | ||
| position: relative; | ||
| display: block; | ||
| line-height: 60px; | ||
| } | ||
|
|
||
| .nav__link:hover { | ||
| color: var(--color-blue); | ||
| } | ||
|
|
||
| .nav__list { | ||
| padding: 0; | ||
| list-style: none; | ||
| display: flex; | ||
| margin: 0; | ||
| } | ||
|
|
||
| .nav__item:not(:last-child) { | ||
| margin-right: 20px; | ||
| } | ||
|
|
||
| .nav__link.is-active { | ||
| color: var(--color-blue); | ||
| } | ||
|
|
||
| .is-active::after { | ||
| content: ""; | ||
| background-color: var(--color-blue); | ||
| border-radius: 2px; | ||
| width: 100%; | ||
| height: 4px; | ||
| position: absolute; | ||
| bottom: 0; | ||
| left: 0; | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This selector for the hover effect is not working because the
<a>elements in the HTML are missing thenav__linkclass. The same issue applies to the.nav__link.is-activeselector on line 43.