Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work on the overall structure and layout! The HTML is semantic, and you've used flexbox effectively to match the design.
However, changes are needed in src/style.css because it violates a core requirement of the project. Styling elements by tag name is not allowed, except for html and body. Your code currently applies styles directly to the ul and a tags.
Please move the styles from the ul selector to the .nav__list class, and the styles from the a selector to the appropriate classes like .nav__link. After you've made these adjustments, your work will be ready for approval!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this submission! I'm happy to approve your solution. You've done a fantastic job of addressing the feedback from the previous review, especially by refactoring your CSS to use class selectors instead of tag selectors. Your HTML is semantic and well-structured, and the project now meets all requirements perfectly. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
DEMO LINK
TEST REPORT LINK
[ x ] Header height is set in 1 place (for the links)
[ x ] Content is vertically centered (for any header height)
[ x ] CSS is used to show all letters in Uppercase (don't type them in HTML)
[ x ] Logo is an image wrapped with a link
[ x ] CSS Variable is used for a blue color
[ x ] Pseudo-element is used for a blue line below the active link
[ x ] Code follows all the Code Style Rules ❗️
[ x ] The Google Fonts Configuration follows requirements.
