Skip to content

add task solution#7494

Open
StasParubets wants to merge 1 commit intomate-academy:masterfrom
StasParubets:develop
Open

add task solution#7494
StasParubets wants to merge 1 commit intomate-academy:masterfrom
StasParubets:develop

Conversation

@StasParubets
Copy link

DEMO LINK

❗️ Copy this Checklist to the Pull Request description after links, and put - [x] before each point after you checked it.

  • Header height is set in 1 place (for the links)
  • Content is vertically centered (for any header height)
  • CSS is used to show all letters in Uppercase (don't type them in HTML)
  • Logo is an image wrapped with a link
  • CSS Variable is used for a blue color
  • Pseudo-element is used for a blue line below the active link
  • Code follows all the Code Style Rules ❗️
  • The Google Fonts Configuration follows requirements.
    alt text

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Excellent work on this task! I am approving your solution as you've successfully met all the core requirements. The HTML structure is semantic, and the CSS is well-organized, correctly using flexbox for the layout as requested. I have a couple of minor suggestions for you to consider for future projects: In src/index.html, the alt attribute for the logo could be more descriptive. For example, alt="Moyo company logo" is better for accessibility than alt="logo of company". In src/style.css, the top property on your .logo__image has no effect since the element has the default position: static. This line can be safely removed. These are just small refinements. Overall, this is a very strong submission. Keep up the great work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

>
<img
src="images/logo.png"
alt="logo of company"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alt attribute should describe the image content more specifically. While "logo of company" is acceptable, a better value would be "Moyo company logo" to be more descriptive for accessibility and SEO.

}

.logo__image {
top: 10px;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The top property only affects positioned elements (e.g., position: absolute, position: relative, etc.). Since this element's position is static (the default), this property has no effect and can be removed. The vertical alignment of the logo is already handled by align-items: center on the .header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants