Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Good work on the HTML structure and the overall layout using flexbox! However, a few adjustments are needed in your CSS to meet all the project requirements.
Here are the key points to address:
- Tag Selector: In
src/style.css, the rule.logo imgstyles animgtag directly, which is not allowed. Please add a class to the<img>element in your HTML and use that class for styling. - CSS Variable Usage: The hover effect for links uses a hardcoded color (
#00acdc). Since you've already defined--color, please usevar(--color)for the.nav__link:hoverstate to comply with the requirements [CHECKLIST ITEM #5]. - Font Weight: The task requires the Roboto font with a medium weight of
500, butfont-weight: normalis being used. Please update this to500.
You're very close to a perfect solution. Please make these changes and resubmit!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
|
[x]Header height is set in 1 place (for the links) |
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work on addressing the previous feedback! You're very close to a complete solution. However, changes are needed because a critical CSS selector issue is causing the automated visual tests to fail. In src/style.css, the selector .logo.logo_item is incorrect because it targets an element with both classes, but in your HTML the <a> and <img> have these classes separately. Please change it to .logo .logo_item or just .logo_item to correctly size the logo and fix the layout. Please also address the other minor points from the review comments regarding the generic alt text and redundant CSS top properties. Fixing the main selector issue should get the tests to pass!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this task! I'm happy to approve your solution as it meets all the requirements. Your code is clean, well-structured, and you've done a great job addressing all the feedback from the previous review.
I have a couple of minor suggestions to make your CSS even more robust for the future:
- In
src/style.css, thefont-style: normal;property is the default value, so it's redundant and can be removed. - For the active link's underline, using
bottom: 0;instead oftop: 56px;would be a more flexible solution that adapts if the link's height ever changes.
These are just small tips for future projects. Overall, this is a fantastic submission. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
No description provided.