Conversation
Implement cinema visit functionality with customer and staff interactions.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work on implementing the logic for each class and the main function! The code itself is well-written. However, this submission requires changes because of a critical issue with the project's directory structure that prevents the program from running.
Specifically, the bar.py and hall.py files are located in the app/people directory, but they should be in an app/cinema directory as required by the task. This causes the imports in app/main.py to fail with an ImportError.
Please fix this by creating the app/cinema directory and moving bar.py and hall.py into it. After you correct the file paths, everything should work as expected!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| @@ -1,6 +1,24 @@ | |||
| # write your imports here | |||
| from app.cinema.bar import CinemaBar | |||
There was a problem hiding this comment.
This import will raise an ImportError. According to the requirements, the bar.py module should be in the app/cinema package, but in your submission, it is located in app/people.
| @@ -1,6 +1,24 @@ | |||
| # write your imports here | |||
| from app.cinema.bar import CinemaBar | |||
| from app.cinema.hall import CinemaHall | |||
There was a problem hiding this comment.
This import will raise an ImportError. According to the requirements, the hall.py module should be in the app/cinema package, but in your submission, it is located in app/people.
| @@ -0,0 +1,4 @@ | |||
| class CinemaBar: | |||
There was a problem hiding this comment.
This file is misplaced. The CinemaBar class should be in the app/cinema/ package, specifically in the app/cinema/bar.py file, as specified in the task description.
| @@ -0,0 +1,10 @@ | |||
| class CinemaHall: | |||
There was a problem hiding this comment.
This file is in the wrong location. The task description specifies that the CinemaHall class should be in the app/cinema/hall.py module, but it's currently in app/people/hall.py.
|
cinema |
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this submission! You've successfully addressed the previous feedback and corrected the project's directory structure. All classes and methods are now implemented perfectly according to the task requirements, and the logic in main.py correctly simulates the cinema visit. The output matches the example exactly. Your solution is being approved, keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.