-
-
Notifications
You must be signed in to change notification settings - Fork 33
Configurable separator support #233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without the PR with french locale with mate-calc 1.26 debian
- 1.5+2 (decimal = numeric keypad)
- 1.5+2 (decimal = point/dot)
- 1,5+2 (decimal = coma)
Without the PR with french locale with mate-calc 1.28 fedora
- 1.5+2 (decimal = numeric keypad)
- 1,5+2 (decimal = coma)
- 1.5+2 (decimal = point/dot)
Without the PR with c locale with mate-calc 1.26 debian & 1.28 fedora
- 1.5+2 (decimal = numeric keypad)
- 1,5+2 (decimal = coma)
With the PR with c locale it's working by rebuilding Debian 1.26 source package:
- 1.5+2 (decimal = numeric keypad)
- 1,5+2 (decimal = coma)
but when I press the coma, I have a warning:
fabrice@mario:~$ LC_ALL=c mate-calc
(process:6353): Gtk-WARNING **: 10:26:47.061: Locale not supported by C library.
Using the fallback 'C' locale.
(mate-calc:6353): Gtk-WARNING **: 10:26:48.358: Invalid text buffer iterator: either the iterator is uninitialized, or the characters/pixbufs/widgets in the buffer have been modified since the iterator was created.
You must use marks, character numbers, or line numbers to preserve a position across buffer modifications.
You can apply tags and insert marks without invalidating your iterators,
but any mutation that affects 'indexable' buffer contents (contents that can be referred to by character offset)
will invalidate all outstanding iterators
|
warning fixed |
vkareh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't work properly for me. Running as LANG=fr_FR mate-calc:
- ✔️ if I type
123,456+1the result is124,456 - ❌ if I type
123.456+1I expect the result to be123.457, but it's the same as the previous one:124,456, which is incorrect in both result and display...
I think this PR should take into account the locale, rather than just accepting a comma arbitrarily.
…eriod (.) and comma (,) as decimal separators.
🔍 Static Analysis ResultsCode analysis completed for this pull request.
The detailed reports are available in the workflow artifacts. |
Now mate-calc supports both period (.) and comma (,) as decimal separators.
fixes #34