Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
LWUand remainder/divide-by-zero return values to match the architecture definition.Description
LWUto zero-extend the 32-bit loaded word into the 64-bit register by assigningu64::from(mem).MUL,MULH,MULHSU, andMULHUto perform full-width multiplications and extract the correct 64-bit high/low halves using 128-bit intermediate arithmetic.REM/REMUto return the dividend when the divisor is zero, and keep the existing signed DIV/unsigned DIV behavior for divide-by-zero.MULWnow multiplies 32-bit signed operands,DIVWadds thei32::MIN / -1overflow check, andREMW/REMUWreturn the sign- or zero-extended dividend when the divisor is zero.Testing
cargo testand thetests/rv64*cases) in CI to validate instruction-level behavior.Codex Task