Merge "Remove additional BottomAppBar menu item"

hunterstich · Gerrit Code Review · commit 473e0bbd0471 · 2019-10-17T18:33:20.000Z
diff --git a/app/src/main/java/com/materialstudies/reply/ui/MainActivity.kt b/app/src/main/java/com/materialstudies/reply/ui/MainActivity.kt
@@ -192,7 +192,7 @@ class MainActivity : AppCompatActivity(),
 
     override fun onMenuItemClick(item: MenuItem?): Boolean {
         when (item?.itemId) {
-            R.id.menu_theme -> {
+            R.id.menu_settings -> {
                 bottomNavDrawer.close()
                 showDarkThemeMenu()
             }
diff --git a/app/src/main/res/drawable/ic_wb_sunny_on_branded.xml b/app/src/main/res/drawable/ic_wb_sunny_on_branded.xml
diff --git a/app/src/main/res/menu/bottom_app_bar_settings_menu.xml b/app/src/main/res/menu/bottom_app_bar_settings_menu.xml
@@ -15,17 +15,10 @@
 <menu xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto">
 
-    <item
-        android:id="@+id/menu_theme"
-        android:icon="@drawable/ic_wb_sunny_on_branded"
-        app:showAsAction="ifRoom"
-        android:title="Theme"/>
-
     <item
         android:id="@+id/menu_settings"
         android:icon="@drawable/ic_settings_on_branded"
         app:showAsAction="ifRoom"
         android:title="Settings"/>
 
-
 </menu>

Original file line number	Diff line number	Diff line change
`@@ -192,7 +192,7 @@ class MainActivity : AppCompatActivity(),`
`192`	`192`
`193`	`193`	`override fun onMenuItemClick(item: MenuItem?): Boolean {`
`194`	`194`	`when (item?.itemId) {`
`195`		`- R.id.menu_theme -> {`
	`195`	`+ R.id.menu_settings -> {`
`196`	`196`	`bottomNavDrawer.close()`
`197`	`197`	`showDarkThemeMenu()`
`198`	`198`	`}`