Skip to content

fix(dialog): scrollbar Flash on opening #5121 #5802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(dialog): scrollbar Flash on opening #5121 #5802

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b861fe
scroller overflow-y: scroll -> auto; content overflow-y: clip
bipedal-eel May 12, 2025
5b75beb
.scroller false while opening
bipedal-eel May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion dialog/internal/_dialog.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@
// space from appearing on platforms that reserve scrollbar space.
// Note: we only scroll vertically. Horizontal scrolling should be handled
// by the content.
overflow-y: scroll;
overflow-y: auto;
}

.content {
Expand All @@ -185,6 +185,7 @@
font-weight: map.get($tokens, 'supporting-text-weight');
height: min-content; // Needed for Safari
position: relative;
overflow-y: clip; // Needed for .scrollable .scroller
}

slot[name='content']::slotted(*) {
Expand Down