Skip to content

feat: update JS and CSS icons to be more pixel perfect#2895

Merged
PKief merged 1 commit intomainfrom
feat/pixel-perfect-icons
Feb 22, 2025
Merged

feat: update JS and CSS icons to be more pixel perfect#2895
PKief merged 1 commit intomainfrom
feat/pixel-perfect-icons

Conversation

@PKief
Copy link
Copy Markdown
Member

@PKief PKief commented Feb 19, 2025

Description

As mentioned by @sgup, it makes sense to also update the JS icons regarding pixel perfectness. Unify the square shape of JS map and CSS map icons.

#2878 (comment)

Contribution Guidelines

@github-actions github-actions bot added the icons PR with new icons label Feb 19, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Preview

Thank you for creating a pull request. This preview shows you how your icons will look on the different themes:

Generated preview

Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

@PKief PKief requested a review from lucas-labs February 19, 2025 17:54
Copy link
Copy Markdown
Member

@lucas-labs lucas-labs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@PKief PKief merged commit 626af9c into main Feb 22, 2025
9 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the Marketplace.

@PKief PKief deleted the feat/pixel-perfect-icons branch February 22, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

icons PR with new icons

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants