Skip to content

feat: update prettier icon#2904

Merged
lucas-labs merged 4 commits intomaterial-extensions:mainfrom
rowan-walsh:update-prettier-icon
Feb 25, 2025
Merged

feat: update prettier icon#2904
lucas-labs merged 4 commits intomaterial-extensions:mainfrom
rowan-walsh:update-prettier-icon

Conversation

@rowan-walsh
Copy link
Copy Markdown
Contributor

Description

Update Prettier icon to display better at standard resolution: previously the shapes were all smaller than a pixel at 16x16 which led to it blurring out.

Contribution Guidelines

@github-actions github-actions bot added the icons PR with new icons label Feb 23, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 23, 2025

Preview

Thank you for creating a pull request. This preview shows you how your icon will look on the different themes:

Generated preview

Check how your icon fits in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

@PKief PKief requested a review from lucas-labs February 24, 2025 07:45
Copy link
Copy Markdown
Member

@lucas-labs lucas-labs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

The only problem I can see is that it's a bit hard to see in light themes. But the same is happening already with the original icon.

We could try using a slightly darker palette and see how it goes.

e.g.:

  • #00897B instead of #4DB6AC
  • #BA68C8 instead of #CE93D8
  • ...etc

..within Material color pallette.
@rowan-walsh
Copy link
Copy Markdown
Contributor Author

Shifted 1-2 shades darker. Its a bit better, the yellow will always be a challenge. For side-by-side comparison:

Old
image

New
image

@PKief
Copy link
Copy Markdown
Member

PKief commented Feb 25, 2025

Shifted 1-2 shades darker. Its a bit better, the yellow will always be a challenge. For side-by-side comparison:

I think it is nice like that. Thanks for the adjustments. The yellow colors are always a little bit difficult on light themes but I think we found a good solution now :)

@lucas-labs lucas-labs merged commit 65a2926 into material-extensions:main Feb 25, 2025
4 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the Marketplace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

icons PR with new icons

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants