Skip to content

feat: add navigation folder icon#2927

Merged
PKief merged 1 commit intomainfrom
PKief/issue2926
Mar 13, 2025
Merged

feat: add navigation folder icon#2927
PKief merged 1 commit intomainfrom
PKief/issue2926

Conversation

@PKief
Copy link
Copy Markdown
Member

@PKief PKief commented Mar 6, 2025

Description

Add navigation folder icon. I've used a hamburger as it's the typical icon for a menu / navigation.

Contribution Guidelines

@PKief PKief self-assigned this Mar 6, 2025
@github-actions github-actions bot added the icons PR with new icons label Mar 6, 2025
@PKief PKief linked an issue Mar 6, 2025 that may be closed by this pull request
3 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 6, 2025

Preview

Thank you for creating a pull request. This preview shows you how your icons will look on the different themes:

Generated preview

Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

@okaybeydanol
Copy link
Copy Markdown

@PKief I believe the "navigation" folder in React Native serves the same purpose as the "routes" folder, so the icon should be consistent with the one used for "routes." Using a hamburger menu icon doesn't make sense, as it's typically associated with opening a menu inside an app, not with navigation setup in a project folder structure.

The "navigation" folder should ideally use an icon that matches "routes," such as an arrow or a symbol directly related to navigation, rather than a hamburger menu.

Additionally, I noticed that the icon added is for "folder-navigation-open" or "folder-navigation." I only want the "navigation" icon to be applied to the folder itself, not in the open state or a different variant.

@lucas-labs
Copy link
Copy Markdown
Member

... I noticed that the icon added is for "folder-navigation-open" or "folder-navigation." I only want the "navigation" icon to be applied to the folder itself, not in the open state or a different variant.

All folder icons in this icon theme have open and closed states.

@okaybeydanol
Copy link
Copy Markdown

@PKief @lucas-labs Thank you! However, the "navigation" folder should have the exact same icon as the "routes" folder for both its open and closed states.
The hamburger menu icon is not the right choice, as it represents a UI element rather than project navigation. Since the "navigation" folder serves the same purpose as the "routes" folder, its icon should be identical. Please apply the same icon used for the "routes" folder.

@PKief
Copy link
Copy Markdown
Member Author

PKief commented Mar 13, 2025

@okaybeydanol I can update it. Until then you can also set this into your user settings to change the behavior:

"material-icon-theme.folders.associations": {
  "navigation": "routes"
}

@PKief PKief force-pushed the PKief/issue2926 branch from 2dc8bc1 to e6da700 Compare March 13, 2025 17:51
@PKief PKief merged commit 98049a5 into main Mar 13, 2025
6 checks passed
@PKief PKief deleted the PKief/issue2926 branch March 13, 2025 17:54
@github-actions
Copy link
Copy Markdown
Contributor

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the Marketplace.

@okaybeydanol
Copy link
Copy Markdown

I was normally using it like that, but thanks @PKief lot, it has already been fixed. I'll see if there is an update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

icons PR with new icons

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Icon Request]: navigation

3 participants