Skip to content

feat(icons): add PackShip package builder icon#2947

Merged
PKief merged 22 commits intomaterial-extensions:mainfrom
PackShip:feat/packship-icon
Apr 12, 2025
Merged

feat(icons): add PackShip package builder icon#2947
PKief merged 22 commits intomaterial-extensions:mainfrom
PackShip:feat/packship-icon

Conversation

@CodeNKoffee
Copy link
Copy Markdown
Contributor

I'll help you create a PR description following the required format for the Material Icon Theme repository. Below is a properly formatted PR description:

Description

  • Added new icon for PackShip npm package builder
  • Added file associations for PackShip configuration files (.packshiprc, packship.config.js, packship.config.mjs, packship.config.ts, packship.config.mts)
  • Created a simplified SVG icon that follows Material Design guidelines and matches the theme style

Contribution Guidelines

@github-actions github-actions bot added the icons PR with new icons label Mar 24, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 24, 2025

Preview

Thank you for creating a pull request. This preview shows you how your icon will look on the different themes:

Generated preview

Check how your icon fits in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

Signed-off-by: Hatem Soliman <96267016+CodeNKoffee@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

@CodeNKoffee CodeNKoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed redundant package-lock json file created by myself accidentally

@lucas-labs
Copy link
Copy Markdown
Member

Hi! Thanks for your PR!

All icons in this theme have at least 1px margins.

Also, we never use pure white or black (#ffffff, #000000). This is to avoid contrast and visibility issues in different vscode themes.

You can find more info in our contribution guidelines.

Cheers!

@CodeNKoffee
Copy link
Copy Markdown
Contributor Author

Hi! Thanks for your PR!

All icons in this theme have at least 1px margins.

Also, we never use pure white or black (#ffffff, #000000). This is to avoid contrast and visibility issues in different vscode themes.

You can find more info in our contribution guidelines.

Cheers!

Hey there @lucas-labs ,

Thanks for shedding light on the parts I missed. I have gone through the contribution guidelines and have amended the following as requested + in addition to adding some extra modifications:

  1. Added light and dark mode icon variants
  2. Simplified recognized file extensions

Signed-off-by: Hatem Soliman <96267016+CodeNKoffee@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

@CodeNKoffee CodeNKoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted package-lock.json accidentally added by myself.

@PKief PKief linked an issue Mar 27, 2025 that may be closed by this pull request
3 tasks
@PKief
Copy link
Copy Markdown
Member

PKief commented Mar 27, 2025

@CodeNKoffee thanks for creating the PR. I was doing a small research about PackShip and found out that it's not heavily used by many people. At least on Github.com I could only find some files of you using this project:

It has 1 star on Github:

image

Don't get me wrong, typically we don't have the requirement of some stars or usages. But I'm also not sure if we should support every niche project. Can you maybe prove me wrong and tell me that there're more people having some use of this Pull Request?

@CodeNKoffee
Copy link
Copy Markdown
Contributor Author

CodeNKoffee commented Mar 29, 2025

@CodeNKoffee thanks for creating the PR. I was doing a small research about PackShip and found out that it's not heavily used by many people. At least on Github.com I could only find some files of you using this project:

It has 1 star on Github:

image Don't get me wrong, typically we don't have the requirement of some stars or usages. But I'm also not sure if we should support every niche project. Can you maybe prove me wrong and tell me that there're more people having some use of this Pull Request?

Thanks for your feedback! You're right that PackShip is relatively new in the open-source world. It actually started as a commercial product with several paying customers, similar to how Remix began as paid software before going open source.

While GitHub stars and public usage might seem limited now, we're in a growth phase with several contributors working to expand adoption. I have a strong track record of delivering successful projects (you can check my LinkedIn and GitHub profiles for verification), and I believe PackShip has significant potential.

By accepting this PR, you'd be contributing to its growth trajectory. I'm confident that with continued development and community support, PackShip could see substantial adoption within a year.

N.B. PackShip did get an acquisition offer a few months back before it turned open-source :)

I'm sure you will be willing to reconsider the PR given this context.

Thanks in advance https://packship.dev

@CodeNKoffee
Copy link
Copy Markdown
Contributor Author

@lucas-labs @PKief can you kindly check the updated branch for the requested changes?

Thanks in advance

@PKief PKief changed the title feat(icons): add PackShip package builder icon #2943 feat(icons): add PackShip package builder icon Apr 2, 2025
@PKief
Copy link
Copy Markdown
Member

PKief commented Apr 2, 2025

@lucas-labs @PKief can you kindly check the updated branch for the requested changes?

Thanks in advance

Usually we try to avoid the usage of white and black colors and use some different colors instead:

image

https://github.com/material-extensions/vscode-material-icon-theme/blob/main/CONTRIBUTING.md#use-material-design-colors

I'm not totally happy with that white border as we typically try to keep the icons as simple as possible. If it's necessary we can keep the icon like that, but I feel that a monochrome (using a single color only) version would be more beneficial.

@CodeNKoffee
Copy link
Copy Markdown
Contributor Author

@lucas-labs @PKief can you kindly check the updated branch for the requested changes?
Thanks in advance

Usually we try to avoid the usage of white and black colors and use some different colors instead:

image https://github.com/material-extensions/vscode-material-icon-theme/blob/main/CONTRIBUTING.md#use-material-design-colors

I'm not totally happy with that white border as we typically try to keep the icons as simple as possible. If it's necessary we can keep the icon like that, but I feel that a monochrome (using a single color only) version would be more beneficial.

Hey! I understand that pure black and pure white aren't permitted due to their high contrast. In my original design, the white was placed within and bordered by a vibrant purple, which made it more visually balanced. However, I've updated my logo to use a single, brighter shade of purple that aligns with both themes.

Thanks again for your help and support in addition to your review in advance.

@CodeNKoffee
Copy link
Copy Markdown
Contributor Author

@lucas-labs @PKief can you kindly check the updated branch for the requested changes?
Thanks in advance

Usually we try to avoid the usage of white and black colors and use some different colors instead:
image
https://github.com/material-extensions/vscode-material-icon-theme/blob/main/CONTRIBUTING.md#use-material-design-colors
I'm not totally happy with that white border as we typically try to keep the icons as simple as possible. If it's necessary we can keep the icon like that, but I feel that a monochrome (using a single color only) version would be more beneficial.

Hey! I understand that pure black and pure white aren't permitted due to their high contrast. In my original design, the white was placed within and bordered by a vibrant purple, which made it more visually balanced. However, I've updated my logo to use a single, brighter shade of purple that aligns with both themes.

Thanks again for your help and support in addition to your review in advance.

All good @PKief ? 👀 😃

@PKief
Copy link
Copy Markdown
Member

PKief commented Apr 9, 2025

See the changes

I reduced the file size of the SVG from 12KB to 2KB by recreating the shape and adjusted the color to be from Material Design Color Palette #9575CD.

If it's fine for you we can merge it.

@PKief
Copy link
Copy Markdown
Member

PKief commented Apr 9, 2025

@CodeNKoffee actually your project is quite cool, I checked it out today and played around with it and it's some solid work. Keep going with it :)

@CodeNKoffee
Copy link
Copy Markdown
Contributor Author

@CodeNKoffee actually your project is quite cool, I checked it out today and played around with it and it's some solid work. Keep going with it :)

Thanks man, appreciate the honesty and you trying it out! I strongly believe it'll grow beyond your average bedroom project.

Thanks again, stargazer ;)

@CodeNKoffee
Copy link
Copy Markdown
Contributor Author

@CodeNKoffee actually your project is quite cool, I checked it out today and played around with it and it's some solid work. Keep going with it :)

Also, do you mind sharing your awesome feedback?

@PKief PKief merged commit 1142cee into material-extensions:main Apr 12, 2025
5 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the Marketplace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

icons PR with new icons

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Icon Request]: PackShip - npm package builder

3 participants