feat(icons): add PackShip package builder icon#2947
feat(icons): add PackShip package builder icon#2947PKief merged 22 commits intomaterial-extensions:mainfrom
Conversation
PreviewThank you for creating a pull request. This preview shows you how your icon will look on the different themes: Check how your icon fits in a 16x16 grid with our Pixel Perfect Checker by following this link. You can find more information on how to contribute in the contribution guidelines. |
Signed-off-by: Hatem Soliman <96267016+CodeNKoffee@users.noreply.github.com>
CodeNKoffee
left a comment
There was a problem hiding this comment.
removed redundant package-lock json file created by myself accidentally
|
Hi! Thanks for your PR! All icons in this theme have at least 1px margins. Also, we never use pure white or black ( You can find more info in our contribution guidelines. Cheers! |
…nd to avoid contrasting according to guidelines
Hey there @lucas-labs , Thanks for shedding light on the parts I missed. I have gone through the contribution guidelines and have amended the following as requested + in addition to adding some extra modifications:
|
Signed-off-by: Hatem Soliman <96267016+CodeNKoffee@users.noreply.github.com>
CodeNKoffee
left a comment
There was a problem hiding this comment.
Deleted package-lock.json accidentally added by myself.
|
@CodeNKoffee thanks for creating the PR. I was doing a small research about PackShip and found out that it's not heavily used by many people. At least on Github.com I could only find some files of you using this project: It has 1 star on Github:
Don't get me wrong, typically we don't have the requirement of some stars or usages. But I'm also not sure if we should support every niche project. Can you maybe prove me wrong and tell me that there're more people having some use of this Pull Request? |
Thanks for your feedback! You're right that PackShip is relatively new in the open-source world. It actually started as a commercial product with several paying customers, similar to how Remix began as paid software before going open source. While GitHub stars and public usage might seem limited now, we're in a growth phase with several contributors working to expand adoption. I have a strong track record of delivering successful projects (you can check my LinkedIn and GitHub profiles for verification), and I believe PackShip has significant potential. By accepting this PR, you'd be contributing to its growth trajectory. I'm confident that with continued development and community support, PackShip could see substantial adoption within a year. N.B. PackShip did get an acquisition offer a few months back before it turned open-source :) I'm sure you will be willing to reconsider the PR given this context. Thanks in advance https://packship.dev |
|
@lucas-labs @PKief can you kindly check the updated branch for the requested changes? Thanks in advance |
Usually we try to avoid the usage of white and black colors and use some different colors instead:
I'm not totally happy with that white border as we typically try to keep the icons as simple as possible. If it's necessary we can keep the icon like that, but I feel that a monochrome (using a single color only) version would be more beneficial. |
…scode-material-icon-theme into feat/packship-icon
Hey! I understand that pure black and pure white aren't permitted due to their high contrast. In my original design, the white was placed within and bordered by a vibrant purple, which made it more visually balanced. However, I've updated my logo to use a single, brighter shade of purple that aligns with both themes. Thanks again for your help and support in addition to your review in advance. |
All good @PKief ? 👀 😃 |
|
See the changes I reduced the file size of the SVG from 12KB to 2KB by recreating the shape and adjusted the color to be from Material Design Color Palette If it's fine for you we can merge it. |
|
@CodeNKoffee actually your project is quite cool, I checked it out today and played around with it and it's some solid work. Keep going with it :) |
Thanks man, appreciate the honesty and you trying it out! I strongly believe it'll grow beyond your average bedroom project. Thanks again, stargazer ;) |
Also, do you mind sharing your awesome feedback? |
Merge SuccessfulThanks for your contribution! 🎉 The changes will be part of the upcoming update on the Marketplace. |







I'll help you create a PR description following the required format for the Material Icon Theme repository. Below is a properly formatted PR description:
Description
.packshiprc,packship.config.js,packship.config.mjs,packship.config.ts,packship.config.mts)Contribution Guidelines