fix(#2956): 🚑 firebase icon not working#2957
Conversation
Svgo broke the new firebase file icon during release v5.21.0. The file was quite complex, using `transforms` and other stuff that svgo probably didn't like. This commit doesn't change the shape, just simplifies the svg markup. Closes: material-extensions#2956 Ref: 058ea1c
PreviewThank you for creating a pull request. This preview shows you how your icon will look on the different themes: Check how your icon fits in a 16x16 grid with our Pixel Perfect Checker by following this link. You can find more information on how to contribute in the contribution guidelines. |
PKief
left a comment
PKief
left a comment
There was a problem hiding this comment.
Good catch, thank you very much for fixing it! :)
Merge SuccessfulThanks for your contribution! 🎉 The changes will be part of the upcoming update on the Marketplace. |
|
Sorry for breaking this. I'm pretty sure I originally checked to make sure the svgs work properly, but I probably re-exported them again at the end and I just assumed they would still work instead of checking again. Thanks for the quick fix! |
|
@ciriousjoker don't worry, the svg was a valid svg, but before releasing we run a tool called |
|
Yes, but I checked and this also happens when running the extension locally, so I should have spotted it. |
Our SVG optimizer tool called SVGO only runs while doing a release: It's not part of the local build process. You can also execute it locally by running "bun run preversion" to see the actual changes of it. But it's definitely not your fault. It's not required to run this command locally. |
3 participants
Svgo broke the new firebase file icon during release v5.21.0.
The file was quite complex, using
transformsand other stuff that svgo probably didn't like. This commit doesn't change the shape, just simplifies the svg markup.Closes: #2956
Ref: 058ea1c, #2924
Description
Contribution Guidelines