feat: input folder icon and simulations folder icon

[mattqdev]

Description

• Added new Input-output folder icon (it'll be visible with these folder names: 'input', 'inputs', 'output', 'outputs', 'io')
• Added new Simulations folder icon (it'll be visible with these folder names: 'simulations', 'simulation', 'sim', 'sims')

Contribution Guidelines

• By creating this pull request, I acknowledge that I have read the Contribution Guidelines for this project
• I have read the Code Of Conduct and promise to abide by these rules

[github-actions]

Preview

Thank you for creating a pull request. This preview shows you how your icons will look on the different themes:

Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

[mattqdev]

Hello, I updated the icons as you requested, but I ran into a merging conflict. I hope I solved it manually without any problems.

[lucas-labs]

I feel the icons are lacking a bit of contrast between the folder shapes and the motive shapes. Maybe we can try using a darker shade for the folders, to make the motives a bit more noticeable. Maybe something like:

• #00BCD4
• #AB47BC

[lucas-labs]

Can you take a look at the linting issues reported by the workflow run?

  × Formatter would have printed the following content:
  
    1282 1282 │         {
    1283 1283 │           name: 'folder-input',
    1284      │ - ········folderNames:·['input',·'inputs',·'output',·'outputs',·'io',·'in',·'out'],
         1284 │ + ········folderNames:·[
         1285 │ + ··········'input',
         1286 │ + ··········'inputs',
         1287 │ + ··········'output',
         1288 │ + ··········'outputs',
         1289 │ + ··········'io',
         1290 │ + ··········'in',
         1291 │ + ··········'out',
         1292 │ + ········],
    1285 1293 │         },
    1286 1294 │         {

[mattqdev]

Hello, I had some problems with my github account, so tell me if there is something that isn't working properly or I forget about.

[PKief]

Hello, I had some problems with my github account, so tell me if there is something that isn't working properly or I forget about.

Can you please fix the formatting?

src/core/icons/folderIcons.ts format ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

× Formatter would have printed the following content:

1283 1283 │           name: 'folder-input',
1284 1284 │           folderNames: [
1285      │ - ··········'input',·
1286      │ - ··········'inputs',·
1287      │ - ··········'output',·
1288      │ - ··········'outputs',·
1289      │ - ··········'io',·
1290      │ - ··········'in',·
1291      │ - ··········'out'
     1285 │ + ··········'input',
     1286 │ + ··········'inputs',
     1287 │ + ··········'output',
     1288 │ + ··········'outputs',
     1289 │ + ··········'io',
     1290 │ + ··········'in',
     1291 │ + ··········'out',
1292 1292 │           ],
1293 1293 │         },

[PKief]

you can use the command "bun run format" or "npm run format"

[mattqdev]

Hello, what's the problem right now in my PR?

[mattqdev]

It's everything fine now?

[mattqdev]

Sorry @PKief, can you check please if my PR is now ok?

[lucas-labs]

I'm not completely sure about changing the out folder icon and about using the same icon for both input and output. I'm quite used to the current red icon for the out folder. Might be just me, though.

[lucas-labs]

And also, it seems a bit odd to me that the output folder will now be different from the dist, build (, etc) folders. Many people might expect output and dist to share the same icon, since they usually serve the same purpose in most projects: the place where compilers leave their build artifacts.

I’m having trouble understanding the motivation behind this specific change. Could you please explain the reasoning a bit more?

Thanks!

[mattqdev]

Hey, your suggestion isn't a problem. The initial goal of this PR was to create a folder for simulations and one for inputs, since I'm creating a website with physics simulations and various inputs for the user to control the simulation.

For consistency, I set the same icon for both inputs and outputs, but if you don't like it, I can change it.

So, honestly, I can safely set the old icon for outputs, since I don't use that folder and it wasn't the primary goal of this PR.

Tell me if it's the only problem.

[PKief]

I just updated the icons to be more aligned to our pixel perfect design. I think it looks good now.

[github-actions]

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the Marketplace.