Skip to content

feat(icon): nginx folder icon#3197

Merged
PKief merged 9 commits intomaterial-extensions:mainfrom
lorypelli:patch-2
Mar 9, 2026
Merged

feat(icon): nginx folder icon#3197
PKief merged 9 commits intomaterial-extensions:mainfrom
lorypelli:patch-2

Conversation

@lorypelli
Copy link
Copy Markdown
Contributor

@lorypelli lorypelli commented Oct 1, 2025

Description

Added icon if the folder is named nginx (like php does have)

Contribution Guidelines

@lorypelli
feat(icon): nginx folder icon
6528227 
Signed-off-by: RVG|lory <87276663+LoryPelli@users.noreply.github.com>
@github-actions github-actions bot added the icons PR with new icons label Oct 1, 2025
@lucas-labs
Copy link
Copy Markdown
Member

lucas-labs commented Oct 2, 2025

I think you've missed the svg files for the icon in your commit.

@lorypelli
Copy link
Copy Markdown
Contributor Author

lorypelli commented Oct 2, 2025

I think you've missed the svg files for the icon in your commit.

Isn't it the same as the other one for file icon?

@PKief
Copy link
Copy Markdown
Member

PKief commented Oct 2, 2025

@lorypelli you have to create new SVG files for the folders. We don't pick up the file icons automatically. This PR requires:

  • folder-nginx.svg
  • folder-nginx-open.svg

You can find more details in our contribution guidelines: https://github.com/material-extensions/vscode-material-icon-theme/blob/main/CONTRIBUTING.md#create-icon-as-svg

Feel free to ask if you need further support!

@SayanShankhari
Copy link
Copy Markdown
Contributor

SayanShankhari commented Mar 7, 2026

Would these work?

@lorypelli
Copy link
Copy Markdown
Contributor Author

lorypelli commented Mar 7, 2026

Would these work?

Thanks 😉

@lorypelli
Add folder-nginx.svg icon file
91901aa 
Signed-off-by: LoryPelli <87276663+lorypelli@users.noreply.github.com>
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 7, 2026 •
edited
Loading

Preview

Thank you for creating a pull request. This preview shows you how your icons will look on the different themes:

Generated preview

Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

lorypelli added 4 commits March 7, 2026 14:27
@lorypelli
Add new SVG icon for open Nginx folder
31d923f 
Signed-off-by: LoryPelli <87276663+lorypelli@users.noreply.github.com>
@lorypelli
Merge branch 'material-extensions:main' into patch-2
eaf2dd7
@lorypelli
Change grid stroke color to orange in SVG
bc21e08 
Updated the SVG file to change the grid stroke color from red to orange.

Signed-off-by: LoryPelli <87276663+lorypelli@users.noreply.github.com>
@lorypelli
Update grid stroke color in folder-nginx-open.svg
b7174ab 
Changed the stroke color of the grid path in the SVG from red to orange.

Signed-off-by: LoryPelli <87276663+lorypelli@users.noreply.github.com>
@lorypelli
Copy link
Copy Markdown
Contributor Author

lorypelli commented Mar 7, 2026

@SayanShankhari thanks a lot, the PR can finally be merged :)

@SayanShankhari
Copy link
Copy Markdown
Contributor

SayanShankhari commented Mar 7, 2026 •
edited
Loading

@lorypelli , please remove the 16x16 grid, you may use any text editor.
I had just sent you the sample

@lorypelli
Copy link
Copy Markdown
Contributor Author

lorypelli commented Mar 7, 2026

@lorypelli , please remove the 16x16 grid, you may use any text editor.
I had just sent you the sample

I'm not too practiced in things like this sorry, will do it later :)

@lorypelli
Copy link
Copy Markdown
Contributor Author

lorypelli commented Mar 7, 2026

done @SayanShankhari

@SayanShankhari
Copy link
Copy Markdown
Contributor

SayanShankhari commented Mar 7, 2026 •
edited
Loading

I think you've removed nginx icon as well from folder-nginx.svg.
Please copy-paste only the nginx part from folder-nginx-open.svg

Here you go, just replace with these,

@lorypelli
Update folder-nginx.svg with new SVG paths
ef53fda 
Signed-off-by: LoryPelli <87276663+lorypelli@users.noreply.github.com>
@lorypelli
Copy link
Copy Markdown
Contributor Author

lorypelli commented Mar 7, 2026

Done @SayanShankhari (but I didn't remove the nginx logo from the folder, it was just hidden and visible only to me with special glasses...)

lucas-labs
lucas-labs reviewed Mar 7, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@lucas-labs lucas-labs left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small tweaks to make the hexagon in the motive align with the vertical lines in the grid, to get sharper shapes.

@lucas-labs
Apply suggestions from code review
15eb2a6 
Signed-off-by: Lucas Colombo <lucasncolombo@gmail.com>
lucas-labs
lucas-labs approved these changes Mar 7, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@lucas-labs lucas-labs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lorypelli
Copy link
Copy Markdown
Contributor Author

lorypelli commented Mar 7, 2026

LGTM!

@PKief
Copy link
Copy Markdown
Member

PKief commented Mar 8, 2026

@lucas-labs would it be better when we also make the corners of the "N" align with the grid?

Untitled

@PKief PKief merged commit 76b5121 into material-extensions:main Mar 9, 2026
5 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 9, 2026

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the Marketplace.

PKief pushed a commit that referenced this pull request Mar 9, 2026
@lorypelli @lucas-labs @PKief
feat(icon): nginx folder icon (#3197)
4614d8a 
Signed-off-by: RVG|lory <87276663+LoryPelli@users.noreply.github.com>
Signed-off-by: LoryPelli <87276663+lorypelli@users.noreply.github.com>
Signed-off-by: Lucas Colombo <lucasncolombo@gmail.com>
Co-authored-by: Lucas Colombo <lucasncolombo@gmail.com>
@SayanShankhari SayanShankhari mentioned this pull request Mar 25, 2026
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucas-labs lucas-labs lucas-labs approved these changes

Assignees

No one assigned

Labels

icons PR with new icons

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lorypelli @lucas-labs @PKief @SayanShankhari