fix: remove unused bg from vala icon#3216
Merged
PKief merged 2 commits intomaterial-extensions:mainfrom Oct 12, 2025
tsvl:optimize-vala
Merged
fix: remove unused bg from vala icon#3216PKief merged 2 commits intomaterial-extensions:mainfrom tsvl:optimize-vala
PKief merged 2 commits intomaterial-extensions:mainfrom
tsvl:optimize-vala
Conversation
Contributor
PreviewThank you for creating a pull request. This preview shows you how your icon will look on the different themes: Check how your icon fits in a 16x16 grid with our Pixel Perfect Checker by following this link. You can find more information on how to contribute in the contribution guidelines. |
PKief
approved these changes
Oct 12, 2025
Member
PKief
left a comment
PKief
left a comment
There was a problem hiding this comment.
Really good catch, thanks for fixing it!
Contributor
Merge SuccessfulThanks for your contribution! 🎉 The changes will be part of the upcoming update on the Marketplace. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I happened to notice that most of the file size of the Vala svg is a gradient backplate placed outside of the viewbox:
AFAIK removing this shouldn't have any impact on the displayed icon, but reduces the file size from 2.59 KB to 574 bytes which is much more in line with icons of similar complexity.
Contribution Guidelines