Skip to content

feat(-components): as components#3338

Merged
PKief merged 2 commits intomaterial-extensions:mainfrom
rbalet:feat/-components
Feb 5, 2026
Merged

feat(-components): as components#3338
PKief merged 2 commits intomaterial-extensions:mainfrom
rbalet:feat/-components

Conversation

@rbalet
Copy link
Copy Markdown
Contributor

@rbalet rbalet commented Feb 4, 2026

Description

Made -components being understood as components folder.

Attempt to close: #3218 (comment)

Contribution Guidelines

PKief
PKief previously approved these changes Feb 4, 2026
Copy link
Copy Markdown
Member

@PKief PKief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PKief
Copy link
Copy Markdown
Member

PKief commented Feb 4, 2026

@rbalet could you please take a look at the failing unit tests?

6 tests failed:
(fail) folder icons > should configure icon definitions [2.00ms]
(fail) folder icons > should configure custom icon associations [1.00ms]
(fail) folder icons > should disable icon packs
(fail) folder icons > should configure folder icons for light and high contrast [2.00ms]
(fail) folder icons > should generate cloned folder icons config [1.00ms]
(fail) folder icons > should allow interoperability between cloned and user custom associations

@rbalet
Copy link
Copy Markdown
Contributor Author

rbalet commented Feb 5, 2026

@PKief Didn't expected that much test changes, hope is good '^^

@PKief PKief merged commit 6345487 into material-extensions:main Feb 5, 2026
3 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 5, 2026

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the Marketplace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support -components as components etc.

2 participants