Skip to content

feat(icon): add TypeDoc icon#3359

Closed
DogFortune wants to merge 3 commits intomaterial-extensions:mainfrom
DogFortune:issue/3354-typedoc
Closed

feat(icon): add TypeDoc icon#3359
DogFortune wants to merge 3 commits intomaterial-extensions:mainfrom
DogFortune:issue/3354-typedoc

Conversation

@DogFortune
Copy link
Copy Markdown
Contributor

Description

fixes #3354

icon preview

image

vscode preview

image

Contribution Guidelines

@github-actions github-actions bot added the icons PR with new icons label Feb 18, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 18, 2026

Preview

Thank you for creating a pull request. This preview shows you how your icon will look on the different themes:

Generated preview

Check how your icon fits in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

@chiptumor
Copy link
Copy Markdown
Contributor

chiptumor commented Feb 18, 2026

The shape is a bit inaccurate, but on the right track!

@DogFortune
Copy link
Copy Markdown
Contributor Author

@chiptumor I'm sorry, but I had to change the original logo color as it couldn't be used due to regulations.
https://github.com/material-extensions/vscode-material-icon-theme/blob/main/CONTRIBUTING.md#use-material-design-colors

I based the shape of the logo on the original, but I've just noticed that the lengths of the sides are different. My apologies. Thanks for pointing that out!

While I update the icon, I'll switch to Draft PR.

@DogFortune DogFortune marked this pull request as draft February 19, 2026 00:47
@chiptumor
Copy link
Copy Markdown
Contributor

chiptumor commented Feb 19, 2026

@DogFortune

Nice.

I re-read the contributing guidelines and edited my comment to acknowledge the pallete issue soon after posting it.

I opened a pull request (#3360) for this same icon, so if you want to snatch some of its code, let me know, and I'll cancel it.

@DogFortune
Copy link
Copy Markdown
Contributor Author

@chiptumor We have also confirmed with the project members beforehand to ensure that no one has already started creating icons. This is a consideration to avoid taking up the time of those already engaged in icon creation.
#3354 (comment)

However, having reviewed your portfolio, I believe the SVG you created is more lightweight and straightforward, making it well-suited for this project.

In light of the above, I am cancelling this PR. Thank you.

@DogFortune DogFortune closed this Feb 19, 2026
@chiptumor
Copy link
Copy Markdown
Contributor

chiptumor commented Feb 19, 2026

Ah, I understand. I'm still learning the ropes and loops of GH, so I appreciate the leniency.

@DogFortune
Copy link
Copy Markdown
Contributor Author

@chiptumor When tackling an issue next time, we recommend confirming that no other members are already working on it.
Once you've confirmed no one else is working on it, it's best to declare "I'll take this on" within the issue before starting. This prevents other members from taking your work.

Please note that this is not an official policy of this project. It is something I personally practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

icons PR with new icons

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Icon Request]: TypeDoc

2 participants