feat(icon): add json_schema file icon

[SayanShankhari]

Description

Add file icon for JSON schema validation files.
Add entry in fileIcons.ts file.

Should be able to display icon for any "*.schema.json" file.

Resolves: #3312

Thanks @KTrain5169 for raising, thanks @rbalet for the ideas.

Contribution Guidelines

• By creating this pull request, I acknowledge that I have read the Contribution Guidelines for this project
• I have read the Code Of Conduct and promise to abide by these rules

[github-actions]

Preview

Thank you for creating a pull request. This preview shows you how your icon will look on the different themes:

Check how your icon fits in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

[PKief]

Did you put the icons next to each other? I just did and it doesn't come out nice. Could you please align the schema json icon file with the json file to get this PR in? It didn't see this in the first view, but it feels quite strange seeing both icons next to each other:

[SayanShankhari]

You are correct.

But, earlier @rbalet suggested the following, which was created from the original json icon, which is not so much aligned with the grid.

However, it's your call which one to take. Please let us know.

[SayanShankhari]

Have created new icon using existing json icon as base and added check-mark to it.
As mentioned it will not fit grid.

[PKief]

@SayanShankhari Thanks, yeah that's a pitty. I recently investigated that a little bit. I came to the conclusion that I pretty much like how the JSON icon currently looks like. It fits nicely into these theme - but it doesn't fit the grid and it's not so easy to fix it 😬

For example ones lucas tried to make it more pixel perfect, but it actually doesn't look nice:

That's why we're currently still going with that existing JSON icon which doesn't follow the grid, but the JSON icon is used so frequently that it's important that it looks nice. It is an exception to be honest.

If you want to elaborate on that problem a little bit and suggest some new JSON icon which follows the grid a little bit better and still looks nice, I would totally love that solution. Feel free to explore new options here :)

Until then I'll merge this schema icon, it looks good so far, thanks for your efforts!

[github-actions]

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the Marketplace.

[lucas-labs]

@PKief I actually have a few experiments on the json icon, I also have one that is more similar to the current one just (a bit more but not completely) pixel perfect. But tbh, I didn't find it to be a huge improvement so I never sent a PR. They look quite similar

[rbalet]

@lucas-labs I like you addition, would welcome a PR from your side to be honest :)

[PKief]

Hi @lucas-labs thanks for sharing this. Would be nice to see the full SVG in a PR :)