feat(icon): add deprecated/scrap folder icon

[SayanShankhari]

Add open and closed folder icons for deprecated or scrap.

Resolves: #3348

Thanks @opressorMk2 for raising the issue.

Description

Create pair of hollow folder icon having dashed outlines following existing color filled folder as well as 16x16 grid pattern.

Contribution Guidelines

• By creating this pull request, I acknowledge that I have read the Contribution Guidelines for this project
• I have read the Code Of Conduct and promise to abide by these rules

[github-actions]

Preview

Thank you for creating a pull request. This preview shows you how your icons will look on the different themes:

Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link.

You can find more information on how to contribute in the contribution guidelines.

[PKief]

I like the idea but I think we shouldn't merge this approach. To keep consistency with the already existing icons it would be better to decide for another folder icon. It will stand out too much and such an icon with gather more attention as it should get for a deprecated folder icon.

[SayanShankhari]

I am having following few ideas

1. folder having cross symbol inside, denoting not to use
2. folder having blocks erased, creating holes inside
3. shredded folder
4. same folder icons having half the opacity

Or any other, could you please suggest.

@opressorMk2 can you give some more ideas please?

[opressorMk2]

Sorry about the delay...

You already have some good ideas there, especially the cross symbol and half opacity ones.

my ideas:

• folder with strikethrough line across it, like deprecated functions in IDEs
• folder with a small cobweb on it, implying untouched/old

edit:
@SayanShankhari

[PKief]

How about reusing already existing icons?

[SayanShankhari]

Hi @PKief,
I'd already considered the mentioned two.

The archive is closer to deprecated and trash is closer to scrap.
But, sometimes scrap content can be re-used or re-purposed. Just tried to unite the two with a new icon.

If you insist working with existing icon, and not creating new icon at all, then deprecated have to be mapped with archive and scrap can be mapped with trash.

[lucas-labs]

Maybe using a clone of archive with (e.g.) gray colors?

[PKief]

Maybe using a clone of archive with (e.g.) gray colors?

this sounds like a good idea @SayanShankhari can you give it a try?
Here's an example of how to do clones: https://github.com/material-extensions/vscode-material-icon-theme/blob/main/src/core/icons/folderIcons.ts#L1246-L1251 and more details in contribution guidelines

[SayanShankhari]

In that case as discussed earlier, need to add following two entries, will it work this way?

      {
        name: 'folder-deprecated',
        folderNames: ['deprecated'],
        clone: {
          base: 'folder-archive',
          color: 'dark-gray-700',
        },
      },
      {
        name: 'folder-scrap',
        folderNames: ['scrap'],
        clone: {
          base: 'folder-trash',
          color: 'dark-gray-700',
        },
      },

[lucas-labs]

In that case as discussed earlier, need to add following two entries, will it work this way?

@SayanShankhari that should work! I'm not sure how dark-gray-700 would look on dark themes tho. It might bee too dark, but would have to see it to be sure.

In case you didn't know, in vscode you can run this extension from the Run & debug tab.

... (or just press F5), and then you can see how your changes look in the extension host (it will open a new vscode windows with the extension + your changes running).

[SayanShankhari]

You were right. The dark-gray-700 was not even showing anything.
Changed to only dark-700, and now it is showing as follows.
Creating commit with the changes.

[github-actions]

Merge Successful

Thanks for your contribution! 🎉

The changes will be part of the upcoming update on the Marketplace.