feat(icon): assembly file/folder icons#3397
Open
SayanShankhari wants to merge 5 commits intomaterial-extensions:mainfrom
Open
feat(icon): assembly file/folder icons#3397SayanShankhari wants to merge 5 commits intomaterial-extensions:mainfrom
SayanShankhari wants to merge 5 commits intomaterial-extensions:mainfrom
Conversation
Add icons for assembly language file and folder icons. Resolves: material-extensions#3382
Contributor
PreviewThank you for creating a pull request. This preview shows you how your icons will look on the different themes: Check how your icons fit in a 16x16 grid with our Pixel Perfect Checker by following this link. You can find more information on how to contribute in the contribution guidelines. |
Contributor
Author
|
@PKief, @lucas-labs, please review it |
3 tasks
Member
|
@SayanShankhari Thanks for the update. I’m not a fan of the new assembly SVG icon. The new icon might improve recognizability, but I feel the visual style is a downgrade. I’d vote to keep the old icon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Created file and folder icons for assembly language, having alphabetical icon rather than symbolic icon.
Note: Replaced existing assembly icon, which resembles raw binary file, instead of textual assembly code file.
Thanks @Bh0landa for raising the issue.
Contribution Guidelines