You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@minhsueh thank you so much for your contribution, this looks great! And I can confirm it works in my dev environment.
I have 3 questions/suggestions:
How are the numbers for each endpoint or element generated? They appear to be inside static json files, which is fine. But as time passes, the data counts in MP will change, so it would be helpful to have a python script one can run to update these numbers.
Would it be possible to wrap the app in a class that subclass the html.Div? See the thermo_redox_csp or the materials_graph app as an example.
class MPDSApp(html.Div):
class ids:
# define layout components here
def __init__():
super().__init__(children=[# your layout])
# put your layout here
@callback(... ) # put all your callbacks here
Would it be possible for you to add some headers and texts below/above the periodic tables, to help people understand what the figures are for? I understood it because we had a meeting. But for our general user it may not be obvious from a first glance.
Something along the line of "Elemental Distribution for MP structures" for the first figure, and more explanation for the second one.
Hi @yang-ruoxi, thank you for the feedback and the guidelines for modulizing it. Those items are already on my to-do list! :)
I retrieved the static files using the mp-api and will update the query and storage code to run periodically for distribution updates (possibly on a monthly schedule, which can be automated with GitHub Actions).
As for the timeline, I’m aiming to complete this over the weekend since my current schedule is quite busy.
I should thank you for making this contribution @minhsueh . Yes, having a script to run in GitHub Actions will be awesome.
No worries about the timeline. Please take your time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have created a prototype of Materials Project Data Statistics.
I put the related files at mpships/src/mpships/mp_data_stats.
Please let me know if it is the right place, and any suggestions would be appreciated!