chore: add orjson to dependencies #1015
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
orjsonis installed via the indirect dependency ofpymatgen(since v2025.5.28 materialsproject/pymatgen#4411).However, current
mp-apiallows users to use the older versions ofpymatgen, which do not depend onorjson, which causes a runtime error after installation.api/pyproject.toml
Line 24 in 7d50936
Given the situation, I think we have two options: (1) increasing the minimum version of pymatgen or (2) add
orjsonto dependency of mp-api. I think it would be better to adopt (2) sinceorjsonis actually used in the mp-api codebase (even if installingorjsonby increasing the minimum version ofpymatgen, that is indirectly installed. I think the dependency should be declared explicitly).How to replicate the issue
This problem happens when third-party package depends on the specific version of pymatgen, and any version of mp-api.