Deprecated Structure.ntypesp in pymatgen#1105
Merged
JaGeo merged 2 commits intomaterialsproject:mainfrom Jan 23, 2025
Merged
Conversation
jmmshn
force-pushed
the
jmmshn/md
branch
2 times, most recently
from
b5adeab to
fcda528
Compare
Member
|
Thank you @jmmshn ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Structure.ntypespwas replaced byStructure.n_elemsmaterialsproject/pymatgen#3562
This PR allows for both of those within atomate2 for now.