Skip to content

Updated how silhouettes of spheres are drown in ASY #447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Updated how silhouettes of spheres are drown in ASY #447

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
620c07d
better no light
jmmshn-ms Jan 22, 2025
cf8016b
Merge branch 'main' into jmmshn/nolight
jmmshn Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions crystal_toolkit/helpers/asymptote_renderer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,14 +52,17 @@
}

// Draw a sphere without light
void drawSpheres_nolight(triple[] C, real R, pen p=currentpen){
material nlpen = material(diffusepen=opacity(1.0), emissivepen=p, shininess=0);
for(int i=0;i<C.length;++i){
revolution s_rev = sphere(C[i],R);
surface s_surf = surface(s_rev);
draw(s_surf, nlpen);
draw(s_rev.silhouette(100), black+linewidth(3));
}
void drawSpheres_nolight(triple[] C, real R, pen p=currentpen) {
material nlpen = material(diffusepen=opacity(1.0), emissivepen=p, shininess=0);
for(int i=0; i < C.length; ++i) {
revolution s_rev = sphere(C[i], R);
surface s_surf = surface(s_rev);
draw(s_surf, nlpen);
triple normal = -currentprojection.normal; // viewing direction
triple center = C[i];
path3 outline = Circle(center, R, normal);
draw(outline, black+linewidth(3));
}
}

// Draw a cylinder
Expand Down Expand Up @@ -559,7 +562,6 @@ def asy_write_data(
"""
scene_obj_type = input_scene_comp.type
if ASY_OBJS.get(scene_obj_type) is None:
print(scene_obj_type)
return

asy_obj = ASY_OBJS[scene_obj_type]
Expand Down
Loading