Skip to content

Conversation

@jmmshn
Copy link
Contributor

@jmmshn jmmshn commented Dec 27, 2024

Allow Different Azure Authentication Methods

Currently we only use DefaultAzureCredentials to auth.
There are some cases with custom auth rules where relying on the automatically resolving auth chain of DefaultAzureCredentials is too cumbersome and it would be nice to have the option to bypass it.
This PR allows us to directly import different Azure authentication mechansims and use them to authentication on Azure.

The changes here allows the user to just provide a string representation of the credential type for easy serialization, but does technically allow for arbitrary credential classes to be provided.

@jmmshn jmmshn marked this pull request as ready for review December 27, 2024 03:23
@codecov
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.91%. Comparing base (9589881) to head (5f8f988).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1020      +/-   ##
==========================================
+ Coverage   88.84%   88.91%   +0.06%     
==========================================
  Files          46       46              
  Lines        3990     3997       +7     
==========================================
+ Hits         3545     3554       +9     
+ Misses        445      443       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkingsbury rkingsbury merged commit 4ed05b8 into materialsproject:main Dec 28, 2024
10 checks passed
@rkingsbury
Copy link
Collaborator

Thank you @jmmshn !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants