fixed other references to incorrect method name#1033
Merged
rkingsbury merged 2 commits intomaterialsproject:mainfrom Feb 27, 2025
Merged
fixed other references to incorrect method name#1033rkingsbury merged 2 commits intomaterialsproject:mainfrom
rkingsbury merged 2 commits intomaterialsproject:mainfrom
Conversation
…as miswritten as process_items -- example didnt yield an error but also didnt work properly!
Collaborator
|
Thanks for catching, and fixing, @rekumar ! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1033 +/- ##
=======================================
Coverage 88.91% 88.91%
=======================================
Files 46 46
Lines 3997 3997
=======================================
Hits 3554 3554
Misses 443 443 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I fixed the code examples in the quickstart docs
Major changes:
.process_itemsinstead of the correct method.process_item, resulting in no processing being applied. Hopefully this can save others some headache when getting started :)Checklist
ruff. (For guidance in fixing rule violates, see rule list)mypy.Tip: Install
pre-commithooks to auto-check types and linting before every commit: