delete __all__ from 3 modules

starred imports are bad practice and should not be encouraged

Author: janosh

pymatgen/io/abinit/netcdf.py

@@ -35,15 +35,6 @@
 __status__ = "Development"
 __date__ = "Feb 21, 2013M"
 
-__all__ = [
-    "as_ncreader",
-    "as_etsfreader",
-    "NetcdfReader",
-    "ETSF_Reader",
-    "NO_DEFAULT",
-    "structure_from_ncdata",
-]
-
 
 def _asreader(file, cls):
     closeit = False

pymatgen/io/abinit/variable.py

@@ -9,18 +9,8 @@
 
 import numpy as np
 
-__all__ = [
-    "InputVariable",
-]
-
 _SPECIAL_DATASET_INDICES = (":", "+", "?")
-
-_DATASET_INDICES = "".join(list(string.digits) + list(_SPECIAL_DATASET_INDICES))
-
-_INTERNAL_DATASET_INDICES = ("__s", "__i", "__a")
-
-_SPECIAL_CONVERSION = zip(_INTERNAL_DATASET_INDICES, _SPECIAL_DATASET_INDICES)
-
+_DATASET_INDICES = "".join([*string.digits, *_SPECIAL_DATASET_INDICES])
 _UNITS = {
     "bohr": 1.0,
     "angstrom": 1.8897261328856432,
@@ -47,7 +37,7 @@ def __init__(self, name, value, units="", valperline=3):
 
         # Maximum number of values per line.
         self.valperline = valperline
-        if name in ["bdgw"]:
+        if name == "bdgw":
             self.valperline = 2
 
         if isinstance(self.value, Iterable) and isinstance(self.value[-1], str) and self.value[-1] in _UNITS:

pymatgen/io/res.py

@@ -32,8 +32,6 @@
 
     from pymatgen.core.trajectory import Vector3D
 
-__all__ = ["ResProvider", "AirssProvider", "ResIO", "ResWriter", "ResParseError", "ResError"]
-
 
 @dataclass(frozen=True)
 class AirssTITL: