fix: Books without readings being spuriously included in statistics.#674
Merged
mateusz-bak merged 1 commit intomateusz-bak:masterfrom Jul 20, 2025
Merged
fix: Books without readings being spuriously included in statistics.#674mateusz-bak merged 1 commit intomateusz-bak:masterfrom
mateusz-bak merged 1 commit intomateusz-bak:masterfrom
Conversation
It was the case that books without recorded readings would be included in some of the statistics for a specific year. Specifically the shortest/longest, and average pages statistics. It now will only include these books in overall statistics where a specific year isn't provided.
RomanKovtyukh
approved these changes
May 27, 2025
RomanKovtyukh
left a comment
RomanKovtyukh
left a comment
There was a problem hiding this comment.
Review
This change looks good to me.
Further improvement
The file needs some refactoring. We have the same logic copy-pasted multiple times in the file and it's not only for the changes from this PR.
For example having some List<Book> filterBooksByYears(List<int> years) and List<Reading> filterReadingsByYears(List<int> years) would be useful in multiple places in this file.
|
The workflow failures are not related to the PR. Separate PR to fix the workflow: #679 |
Owner
|
Fixes the issue, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was the case that books without recorded readings would be included in some of the statistics for a specific year. Specifically the shortest/longest, and average pages statistics.
It now will only include these books in overall statistics where a specific year isn't provided.