rename and boolify some predicates for open intervals #1825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Turned into a draft to do some cleaning. |
Member
Author
|
cleaning done |
|
|
||
| ### Renamed | ||
| - in set_interval.v | ||
| + `itv_is_ray` -> `itv_is_open_unbounded`, |
Member
There was a problem hiding this comment.
Suggested change
| + `itv_is_ray` -> `itv_is_open_unbounded`, | |
| + `itv_is_ray` -> `itv_is_open_unbounded` |
| ### Renamed | ||
| - in set_interval.v | ||
| + `itv_is_ray` -> `itv_is_open_unbounded`, | ||
| + `itv_is_bd_open` -> `itv_is_oo`, |
Member
There was a problem hiding this comment.
Suggested change
| + `itv_is_bd_open` -> `itv_is_oo`, | |
| + `itv_is_bd_open` -> `itv_is_oo` |
| Definition itv_open_ends (i : interval T) : Prop := | ||
| itv_is_ray i \/ itv_is_bd_open i. | ||
| Definition itv_open_ends (i : interval T) : bool := | ||
| (itv_is_open_unbounded i) || (itv_is_oo i). |
Member
There was a problem hiding this comment.
Suggested change
| (itv_is_open_unbounded i) || (itv_is_oo i). | |
| itv_is_open_unbounded i || itv_is_oo i. |
Member
There was a problem hiding this comment.
We can maybe use Implicit Types (i : interval T) and then some of these definitions can fit on one line.
| if i is `[_, _] then true else false. | ||
|
|
||
| Definition itv_closed_ends (i : interval T) : bool := | ||
| (itv_is_closed_unbounded i) || (itv_is_cc i). |
Member
There was a problem hiding this comment.
Suggested change
| (itv_is_closed_unbounded i) || (itv_is_cc i). | |
| itv_is_closed_unbounded i || itv_is_cc i. |
affeldt-aist
approved these changes
Jan 16, 2026
Member
affeldt-aist
left a comment
affeldt-aist
left a comment
There was a problem hiding this comment.
I think that the change of naming is a clarification and using bool improves the scripts.
affeldt-aist
added
the
enhancement ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
fixes #1823
This PR
itv_open_ends,itv_is_rayanditv_is_bd_openfrom
Proptoboolfor easier use,Checklist
CHANGELOG_UNRELEASED.mdReference: How to document
Merge policy
As a rule of thumb:
all compile are preferentially merged into master.
Reminder to reviewers