Minor fix

Author: FilippoOlivo

pina/data/data_module.py

@@ -157,7 +157,6 @@ class PinaDataModule(LightningDataModule):
     management of different types of Datasets defined in PINA
     """
 
-    # pylint: disable=R0917
     def __init__(
         self,
         problem,
@@ -424,6 +423,8 @@ def test_dataloader(self):
         return self._create_dataloader("test", self.test_dataset)
 
     @staticmethod
+    # Unavoidable pylint error (we need to keep the same signature as the
+    # parent)
     # pylint: disable=W0613
     def _transfer_batch_to_device_dummy(batch, device, dataloader_idx):
         return batch

pina/domain/difference_domain.py

@@ -10,7 +10,6 @@ class Difference(OperationInterface):
     PINA implementation of Difference of Domains.
     """
 
-    # pylint: disable=W0246
     def __init__(self, geometries):
         r"""
         Given two sets :math:`A` and :math:`B` then the

pina/domain/exclusion_domain.py

@@ -11,7 +11,6 @@ class Exclusion(OperationInterface):
     PINA implementation of Exclusion of Domains.
     """
 
-    # pylint: disable=W0246
     def __init__(self, geometries):
         r"""
         Given two sets :math:`A` and :math:`B` then the

pina/domain/intersection_domain.py

@@ -11,7 +11,6 @@ class Intersection(OperationInterface):
     PINA implementation of Intersection of Domains.
     """
 
-    # pylint: disable=W0246
     def __init__(self, geometries):
         r"""
         Given two sets :math:`A` and :math:`B` then the

pina/domain/simplex.py

@@ -134,8 +134,8 @@ def is_inside(self, point, check_border=False):
         point_shift = point_shift.tensor.reshape(-1, 1)
 
         # compute barycentric coordinates
-        # pylint: disable=E1102
-        lambda_ = torch.linalg.solve(
+
+        lambda_ = torch.linalg.solve(  # pylint: disable=E1102
             self._vectors_shifted * 1.0, point_shift * 1.0
         )
         lambda_1 = 1.0 - torch.sum(lambda_)

pina/domain/union_domain.py

@@ -11,7 +11,6 @@ class Union(OperationInterface):
     Union of Domains.
     """
 
-    # pylint: disable=W0246
     def __init__(self, geometries):
         r"""
         PINA implementation of Unions of Domains.

pina/equation/equation_factory.py

@@ -23,6 +23,8 @@ def __init__(self, value, components=None):
             Default is ``None``.
         """
 
+        # input_ is not used but it is necessary to keep the signature for
+        # consistency
         # pylint: disable=W0613
         def equation(input_, output_):
             if components is None:

pina/model/average_neural_operator.py

@@ -26,7 +26,6 @@ class AveragingNeuralOperator(KernelNeuralOperator):
         <https://arxiv.org/abs/2304.13221>`_
     """
 
-    # pylint: disable=R0917
     def __init__(
         self,
         lifting_net,

pina/model/block/convolution_2d.py

@@ -379,6 +379,7 @@ def forward(self, X):
             ).sum(1)
         return conv
 
+    # Avoid too many arguments warning
     # pylint: disable=R0914
     def transpose_no_overlap(self, integrals, X):
         """

pina/model/block/gno_block.py

@@ -28,7 +28,8 @@ def __init__(
         :param edges_features: Number of edge features.
         :param n_layers: Number of layers in edge transformation MLP.
         """
-        # Avoid circular import
+        # Avoid circular import. I need to import FeedForward here
+        # to avoid circular import with FeedForward itself.
         # pylint: disable=import-outside-toplevel
         from ...model.feed_forward import FeedForward
 
@@ -71,7 +72,6 @@ def edge_update(self, edge_attr):
         """
         Updates edge features.
         """
-        # This method is done to avoid pylint warning (W0246)
         return edge_attr
 
     def update(self, aggr_out, x):