Fixing Laplacian operator for vector fields #380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dario-coscia
requested changes
Nov 14, 2024
Collaborator
dario-coscia
left a comment
dario-coscia
left a comment
There was a problem hiding this comment.
Thanks for the PR! I made some minor comments but it looks good.
Can you also do a small test in test_operators.py for vectorial functions?
dario-coscia
added
pr-to-fix
dario-coscia
approved these changes
Nov 18, 2024
Collaborator
dario-coscia
left a comment
dario-coscia
left a comment
There was a problem hiding this comment.
To me it seems very nice, I will merge the PR. I noticed that in test_operator we are not checking the exact value. Maybe let's open a new issue for that. Good job!
dario-coscia
pushed a commit
that referenced
this pull request
Mar 12, 2025
* fix laplacian and tests
dario-coscia
pushed a commit
that referenced
this pull request
Apr 17, 2025
* fix laplacian and tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solving issue #379