Skip to content

Simplify Graph class #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dario-coscia merged 4 commits into from
Mar 3, 2025
Merged

Simplify Graph class #459

dario-coscia merged 4 commits into from
Mar 3, 2025

Conversation

@FilippoOlivo
Copy link
Member

@FilippoOlivo FilippoOlivo commented Feb 23, 2025

No description provided.

@FilippoOlivo FilippoOlivo self-assigned this Feb 23, 2025
@FilippoOlivo FilippoOlivo added pr-to-review Label for PR that are ready to been reviewed v0.2 labels Feb 24, 2025
@dario-coscia
Copy link
Collaborator

dario-coscia commented Feb 24, 2025 •
edited
Loading

@FilippoOlivo Please run the formatter locally python -m black graph.py

@FilippoOlivo FilippoOlivo added pr-to-fix Label for PR that needs modification and removed pr-to-review Label for PR that are ready to been reviewed labels Feb 26, 2025
GiovanniCanali
GiovanniCanali approved these changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@GiovanniCanali GiovanniCanali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @FilippoOlivo for the nice work. Everything is fine for me!

@GiovanniCanali
Copy link
Collaborator

GiovanniCanali commented Feb 26, 2025

Before merging, let's consider this minor improvement: in some cases, graph features are defined within the model's forward pass, derived from the encoding of other graph attributes (e.g., coordinates, additional parameters). In these situations, it would be helpful to initialize the graph with features x=None, allowing the model's forward to set the node features appropriately.
Do you think we could do this @FilippoOlivo @ndem0 @dario-coscia?

@FilippoOlivo FilippoOlivo changed the title Add check length consistency in additional parameters Simplify Graph class Feb 27, 2025
dario-coscia
dario-coscia approved these changes Mar 1, 2025
View reviewed changes
Copy link
Collaborator

@dario-coscia dario-coscia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think now it is very nice and much simpler! Very good the idea of GraphBuilder

@dario-coscia
Copy link
Collaborator

dario-coscia commented Mar 1, 2025 •
edited
Loading

@FilippoOlivo @gc031298 let's merge this one, then we will work on the Condition from another branch/PR, just fix codacy

@FilippoOlivo
Copy link
Member Author

FilippoOlivo commented Mar 2, 2025

@dario-coscia, @gc031298, I have fixed all Codacy warnings that do not require changes to the class logic

@dario-coscia dario-coscia added pr-to-review Label for PR that are ready to been reviewed and removed pr-to-fix Label for PR that needs modification labels Mar 3, 2025
@dario-coscia
Copy link
Collaborator

dario-coscia commented Mar 3, 2025

Good to go!

@dario-coscia dario-coscia merged commit bd5e4a6 into mathLab:0.2 Mar 3, 2025
16 of 17 checks passed
dario-coscia added a commit that referenced this pull request Mar 3, 2025
@FilippoOlivo @dario-coscia
Simplify Graph class (#459)
bd8fba6 
* Simplifying Graph class and adjust tests

---------

Co-authored-by: Dario Coscia <[email protected]>
ndem0 pushed a commit to ndem0/PINA that referenced this pull request Mar 3, 2025
@FilippoOlivo @dario-coscia @ndem0
Simplify Graph class (mathLab#459)
1bbba45 
* Simplifying Graph class and adjust tests

---------

Co-authored-by: Dario Coscia <[email protected]>
dario-coscia added a commit that referenced this pull request Mar 12, 2025
@FilippoOlivo @dario-coscia
Simplify Graph class (#459)
f239cd9 
* Simplifying Graph class and adjust tests

---------

Co-authored-by: Dario Coscia <[email protected]>
FilippoOlivo added a commit that referenced this pull request Mar 13, 2025
@FilippoOlivo @dario-coscia
Simplify Graph class (#459)
e467085 
* Simplifying Graph class and adjust tests

---------

Co-authored-by: Dario Coscia <[email protected]>
ndem0 pushed a commit that referenced this pull request Mar 19, 2025
@FilippoOlivo @dario-coscia @ndem0
Simplify Graph class (#459)
ab6ca78 
* Simplifying Graph class and adjust tests

---------

Co-authored-by: Dario Coscia <[email protected]>
dario-coscia added a commit that referenced this pull request Apr 17, 2025
@FilippoOlivo @dario-coscia
Simplify Graph class (#459)
bfd7ae5 
* Simplifying Graph class and adjust tests

---------

Co-authored-by: Dario Coscia <[email protected]>
GiovanniCanali pushed a commit to GiovanniCanali/PINA that referenced this pull request Dec 2, 2025
@FilippoOlivo @dario-coscia @GiovanniCanali
Simplify Graph class (mathLab#459)
2e9363c 
* Simplifying Graph class and adjust tests

---------

Co-authored-by: Dario Coscia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dario-coscia dario-coscia dario-coscia approved these changes

@GiovanniCanali GiovanniCanali Awaiting requested review from GiovanniCanali

Assignees

@FilippoOlivo FilippoOlivo

Labels

pr-to-review Label for PR that are ready to been reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FilippoOlivo @dario-coscia @GiovanniCanali