Fixing competitive pinn #470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dario-coscia
commented
Mar 1, 2025
dario-coscia
commented
- Removing unnecessary training steps
- Fixing for datadriven mode
dario-coscia
force-pushed
the
fix_competitive_pinn
branch
from
4870e22 to
b9da605
Compare
GiovanniCanali
requested changes
Mar 1, 2025
Collaborator
GiovanniCanali
left a comment
GiovanniCanali
left a comment
There was a problem hiding this comment.
Hi @dario-coscia! Thank you for fixing competitive pinns.
The supervised training now works well, and the code looks more elegant.
However, by running some preliminary tests, I have noticed that the loss being logged is weighted by the discriminator bets. Please, log only unweighted losses.
GiovanniCanali
approved these changes
Mar 1, 2025
Collaborator
Author
Hi! By default, training logs the weighted loss while validation and testing the unweighted ones. |
dario-coscia
added a commit
that referenced
this pull request
Mar 3, 2025
dario-coscia
added a commit
that referenced
this pull request
Mar 3, 2025
ndem0
pushed a commit
to ndem0/PINA
that referenced
this pull request
Mar 3, 2025
dario-coscia
added a commit
that referenced
this pull request
Mar 12, 2025
FilippoOlivo
pushed a commit
that referenced
this pull request
Mar 13, 2025
ndem0
pushed a commit
that referenced
this pull request
Mar 19, 2025
dario-coscia
added a commit
that referenced
this pull request
Apr 17, 2025
GiovanniCanali
pushed a commit
to GiovanniCanali/PINA
that referenced
this pull request
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.