Linear weight update callback #474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiovanniCanali
force-pushed
the
weight_callback
branch
from
d0629c5 to
fe48345
Compare
GiovanniCanali
force-pushed
the
weight_callback
branch
from
fe48345 to
3e7c140
Compare
dario-coscia
requested changes
Mar 4, 2025
Collaborator
dario-coscia
left a comment
dario-coscia
left a comment
There was a problem hiding this comment.
I made a very minimal comment, for the rest it is great!
dario-coscia
approved these changes
Mar 4, 2025
GiovanniCanali
added
the
pr-to-review
ndem0
approved these changes
Mar 6, 2025
dario-coscia
pushed a commit
that referenced
this pull request
Mar 12, 2025
FilippoOlivo
pushed a commit
that referenced
this pull request
Mar 13, 2025
ndem0
pushed a commit
that referenced
this pull request
Mar 19, 2025
dario-coscia
pushed a commit
that referenced
this pull request
Apr 17, 2025
GiovanniCanali
added a commit
to GiovanniCanali/PINA
that referenced
this pull request
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a callback that allows to linearly adjust the weight of a condition from an initial value to a target value over a specified number of epochs. This only works with
ScalarWeightingweighting schema.It would be nice to extend this to allow different updates in addition to the linear one (e.g., exponential or polynomial update).