-
Notifications
You must be signed in to change notification settings - Fork 92
Update CONTRIBUTING.md #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CONTRIBUTING.md
Outdated
|
|
||
| ## Reporting Bugs | ||
|
|
||
| If you find a bug, please open an [issue](https://github.com/your-username/PINA/issues) and include: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is intentional https://github.com/your-username/PINA/issues. Shouldn't it be https://github.com/mathLab/PINA/issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup
CONTRIBUTING.md
Outdated
| - The enhancement you'd like | ||
| - Why it would be useful | ||
| - Any ideas on how to implement it (optional but helpful) | ||
| 3. If you are not sure about (something of) the enhancement, we suggest to open a discussion to confront on that with the PINA community |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of "confront on that" I suggest "talk about it" or "collaborate on it". What do you think?
CONTRIBUTING.md
Outdated
| Before submitting a PR: | ||
|
|
||
| 1. Ensure there’s an open issue related to your contribution (or create one). | ||
| 2. [Fork](https://help.github.com/articles/fork-a-repo) the repository and create a new branch from `main`: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In PINA we have master I guess (not main)
1f54775 to
795e4a4
Compare
7eec394 to
795e4a4
Compare
No description provided.