Skip to content

Conversation

@GiovanniCanali
Copy link
Collaborator

@GiovanniCanali GiovanniCanali commented Mar 25, 2025

Fixes #523

Checks:

  • Does the same problem affect other differential operators? Edit:: Yes.

To do:

  • Cast single string, passed to either components or d attributes, to a list of a strings (length 1) to avoid issues when the string length is greater than 1.
  • Update the documentation: d and components accept as input type both str and list[str].
  • Improve tests to manage labels as strings of different lengths.
  • Remove useless if-else structure in laplacian: the "if" case is handled also in the "else" case.

@GiovanniCanali GiovanniCanali marked this pull request as draft March 25, 2025 11:16
@GiovanniCanali GiovanniCanali marked this pull request as ready for review March 26, 2025 14:57
@GiovanniCanali GiovanniCanali self-assigned this Mar 26, 2025
@GiovanniCanali GiovanniCanali added the pr-to-review Label for PR that are ready to been reviewed label Mar 26, 2025
@dario-coscia
Copy link
Collaborator

Great for me!

@GiovanniCanali GiovanniCanali merged commit b958c0f into mathLab:master Mar 26, 2025
18 of 19 checks passed
@dario-coscia dario-coscia deleted the lap_bug branch March 26, 2025 15:52
MatteB03 pushed a commit to MatteB03/PINA that referenced this pull request Mar 31, 2025
* fix bug in laplace labels

* fix label management and add test
FilippoOlivo pushed a commit to FilippoOlivo/PINA that referenced this pull request Apr 17, 2025
* fix bug in laplace labels

* fix label management and add test
dario-coscia pushed a commit that referenced this pull request Apr 17, 2025
* fix bug in laplace labels

* fix label management and add test
GiovanniCanali added a commit to GiovanniCanali/PINA that referenced this pull request Dec 2, 2025
* fix bug in laplace labels

* fix label management and add test
GiovanniCanali added a commit to GiovanniCanali/PINA that referenced this pull request Dec 2, 2025
* fix bug in laplace labels

* fix label management and add test
GiovanniCanali added a commit to GiovanniCanali/PINA that referenced this pull request Dec 2, 2025
* fix bug in laplace labels

* fix label management and add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-to-review Label for PR that are ready to been reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vector laplacian behaves incorrectly on components with labels longer than one character

3 participants