-
Notifications
You must be signed in to change notification settings - Fork 92
Add SINDy tutorial #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SINDy tutorial #666
Conversation
Code Coverage SummaryResults for commit: df4ea64 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
c1314e8 to
542386e
Compare
dario-coscia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Lorenzo! Very nice and informative tutorial, it's great to see sindy in the PINA ecosystem 😃
I have just some minor comments:
- You wrote twice in the import section
import matplotlib.pyplot as plt - Use \boldsymbol or \mathbf rather than \bm (not all browsers render it correctly)
- Remove this (a bit too technical): Disclaimer: here we are assuming that the dynamical system is autonomous, ... be written as autonomous ones
- In the tutorial you talk about L1 regularization but you are then using weight_decay which enforces L2 regularization, can you change the text accordingly?
Once addressed it can be merged without any problem from my side! Please squash all commits to one commit adding tutorial 23. Thanks again!
GiovanniCanali
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lorenzotomada, thank you for your PR. The tutorial is very insightful and easy to follow, making it a valuable contribution to PINA.
In addition to what has been pointed out in the previous review, I would like to suggest some minor style improvements.
542386e to
bbd2a05
Compare
|
Hi @GiovanniCanali and @dario-coscia , thanks a lot for your feedback! I implemented all the required changes :) |
bbd2a05 to
7ae1e75
Compare
|
@dario-coscia regarding L^1 vs L^2 normalization, I wrote this just before the definition of the solver: Is that ok for you or should I update the code? |
Description
This PR fixes #661.
Checklist