Skip to content

cast sample sizes as integers without warning #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jordanrhall wants to merge 4 commits into
base: master
Choose a base branch
from
Open

cast sample sizes as integers without warning #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5ec699e
cast sample sizes as integers without warning
Nov 18, 2019
1ec4499
Merge branch 'master' into hotfix/logging
Nov 18, 2019
8152262
version-locked scipy
Nov 18, 2019
e2e194b
use pip install instead of setup.py
Nov 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@ install:
- source activate test
- conda install --yes numpy scipy matplotlib pip nose
- pip install setuptools
- python setup.py install
- pip install .

script: python test.py
6 changes: 2 additions & 4 deletions active_subspaces/subspaces.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,10 +170,8 @@ def partition(self, n):
the dimension of the active subspace

"""
if not isinstance(n, int):
#raise TypeError('n should be an integer')
n = int(n)
print(Warning("n should be an integer. Performing conversion."))
# Cast n as an integer.
n = int(n)

m = self.eigenvecs.shape[0]
if n<1 or n>m:
Expand Down
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def readme():
packages=['active_subspaces', 'active_subspaces.utils'],
install_requires=[
'numpy',
'scipy >= 0.15.0',
'scipy >= 0.15.0,<=1.2.2',
'matplotlib'
Copy link
Owner

@mathematicalmichael mathematicalmichael Nov 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll actually try to resolve this in master and let you merge master into this branch so you don't have to worry about it. We just need a "passing status" on this PR and there are a few ways to get there...

],
test_suite='nose.collector',
Expand Down