Skip to content

Decode case insensitive #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Decode case insensitive #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9a6a1f
case-insensitive test
tugrul Apr 18, 2020
967ac02
do not touch case-insensitive
tugrul Apr 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions punycode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const initialN = 128; // 0x80
const delimiter = '-'; // '\x2D'

/** Regular expressions */
const regexPunycode = /^xn--/;
const regexPunycode = /^xn--/i;
const regexNonASCII = /[^\0-\x7F]/; // Note: U+007F DEL is excluded too.
const regexSeparators = /[\x2E\u3002\uFF0E\uFF61]/g; // RFC 3490 separators

Expand Down Expand Up @@ -389,7 +389,7 @@ const encode = function(input) {
const toUnicode = function(input) {
return mapDomain(input, function(string) {
return regexPunycode.test(string)
? decode(string.slice(4).toLowerCase())
? decode(string.slice(4))
: string;
});
};
Expand Down
8 changes: 8 additions & 0 deletions tests/tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,14 @@ const testData = {
'decoded': 'caf\xE9.com',
'encoded': 'xn--caf-dma.com'
},
{
'decoded': 'ÜBER.COM',
'encoded': 'xn--BER-ska.COM'
},
{
'decoded': 'sPhÈRè.com',
'encoded': 'xn--sPhR-nka7q.com'
},
{
'decoded': '\u2603-\u2318.com',
'encoded': 'xn----dqo34k.com'
Expand Down