Allow Chrome to load speech worker from CDN in a page from a file:// URL#1290
Merged
Allow Chrome to load speech worker from CDN in a page from a file:// URL#1290
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1290 +/- ##
==========================================
Coverage 86.71% 86.71%
==========================================
Files 337 337
Lines 83979 83979
Branches 4750 3124 -1626
==========================================
Hits 72826 72826
- Misses 11130 11153 +23
+ Partials 23 0 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem with importing the worker code from a page the was loaded from a
file://URL with Mathjax coming from the CDN. The problem only seems to affect Chrome, which won't allow the cross-origin load, even though the CDN marks the script as allowed.The solution is to use
importScripts()rather thanimport()to get the worker code. That means the worker can't be loaded as a module, asimportScripts()isn't allowed there.The
package.jsonfile is no longer needed, and the worker doesn't need to be a module anymore (that could have been removed when the worker-pool was removed, as that was only needed for the iframe hack to the liteDOM).The v4-lab needs a new way to detect the need for the
sre-lab.jsfile, as theimportScripts()can't load an ES6 module, and the compiledspeech-worker.jsis such a module. So we need to useimport()in the lab. Theww-v4-labbranch in the MathJax-dev repository has the needed changes: the HTML adaptor is subclassed and thecreateWorker()method is overridden with one that usesimport(), and also setsself.isLab = trueto mark the fact that the worker is running int he lab. The worker now uses that value to determine whether to loadsre-lab.jsorsre.js, so that is a bit cleaner than having to test for the failure of SRE loading.