Don't try to create the clearspeak menu if enrichment is disabled#1292
Merged
Don't try to create the clearspeak menu if enrichment is disabled#1292
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1292 +/- ##
========================================
Coverage 86.71% 86.71%
========================================
Files 337 337
Lines 83979 83979
Branches 4750 4750
========================================
Hits 72826 72826
Misses 11130 11130
Partials 23 23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR prevents the menu code from trying to create the clearspeak setting menu when enrichment is off (and so the webworker may not even be created yet). When enrichment is off, the speech menu is disabled, so the clearspeak menu will not be available in that case, so it is OK to not generate it.