Skip to content

Don't try to create the clearspeak menu if enrichment is disabled#1292

Merged
dpvc merged 1 commit intodevelopfrom
fix/clearspeak-menu
Jul 18, 2025
Merged

Don't try to create the clearspeak menu if enrichment is disabled#1292
dpvc merged 1 commit intodevelopfrom
fix/clearspeak-menu

Conversation

@dpvc
Copy link
Copy Markdown
Member

@dpvc dpvc commented Jul 2, 2025

This PR prevents the menu code from trying to create the clearspeak setting menu when enrichment is off (and so the webworker may not even be created yet). When enrichment is off, the speech menu is disabled, so the clearspeak menu will not be available in that case, so it is OK to not generate it.

@dpvc dpvc requested a review from zorkow July 2, 2025 14:43
@dpvc dpvc added this to the v4.0 milestone Jul 2, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.71%. Comparing base (4d1e195) to head (3d27197).
Report is 20 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1292   +/-   ##
========================================
  Coverage    86.71%   86.71%           
========================================
  Files          337      337           
  Lines        83979    83979           
  Branches      4750     4750           
========================================
  Hits         72826    72826           
  Misses       11130    11130           
  Partials        23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit 76a6509 into develop Jul 18, 2025
3 checks passed
@dpvc dpvc deleted the fix/clearspeak-menu branch July 18, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants