Skip to content

Fix regex for quoting file names to include#1300

Merged
dpvc merged 1 commit intodevelopfrom
fix/pack
Jul 18, 2025
Merged

Fix regex for quoting file names to include#1300
dpvc merged 1 commit intodevelopfrom
fix/pack

Conversation

@dpvc
Copy link
Copy Markdown
Member

@dpvc dpvc commented Jul 8, 2025

The + was missing from the regex for quoting file and directory names (argh!).

This causes these to not properly match directories in node_modules when pnpm is used to install dependencies, since it uses hidden directories in .pnpm that include plus signs.

@dpvc dpvc requested a review from zorkow July 8, 2025 11:26
@dpvc dpvc added this to the v4.0 milestone Jul 8, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.71%. Comparing base (4d1e195) to head (efe57da).
Report is 25 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #1300     +/-   ##
==========================================
  Coverage    86.71%   86.71%             
==========================================
  Files          337      337             
  Lines        83979    83979             
  Branches      4750     3124   -1626     
==========================================
  Hits         72826    72826             
- Misses       11130    11153     +23     
+ Partials        23        0     -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@dpvc dpvc merged commit ba96ff0 into develop Jul 18, 2025
3 checks passed
@dpvc dpvc deleted the fix/pack branch July 18, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants